Decouple DevTools from socket implementation.

net/server/http_server.h

Index: net/server/http_server.h
diff --git a/net/server/http_server.h b/net/server/http_server.h
index aaf5336c66de891539737309f58496994d79373b..56435388f771c520da8d70996cc483eb26814780 100644
--- a/net/server/http_server.h
+++ b/net/server/http_server.h
@@ -39,7 +39,12 @@ class HttpServer : public StreamListenSocket::Delegate,
     virtual ~Delegate() {}
   };
 
-  HttpServer(const std::string& host, int port, HttpServer::Delegate* del);
+  // Note that the constructed HttpServer instance does not take ownership of
+  // the provided socket factory. The factory instance is only used here for
+  // construction which means that it does not need to live longer that the
+  // constructor duration.

[pfeldman, 2012/05/14 11:12:00]

Passing a server socket instance here would be self explanatory and would not
need such comment.

[Philippe, 2012/05/14 12:36:52]

Indeed. The initial motivation (still valid in my opinion) for a socket factory
instance rather than a socket instance, is that the socket depends on the
delegate (provided here by HttpServer) at construction time (circular
dependency). A workaround would be to add a setter to StreamListenSocket to set
the delegate once the two objects are constructed. In my opinion the factory
approach is better since it prevents the socket from being in an "intermediate
state" (i.e. delegate_ == NULL). It would also force the user to call
SetDelegate() which he could forget.
If you really don't like this comment, I can also remove it. It's not that
useful.

What do you think?

+  HttpServer(HttpServer::Delegate* delegate,
+             StreamListenSocketFactory* socket_factory);
 
   void AcceptWebSocket(int connection_id,
                        const HttpServerRequestInfo& request);