Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: content/public/browser/devtools_http_handler.h

Issue 10386048: Decouple DevTools from socket implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Pavel's comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_http_handler.h
diff --git a/content/public/browser/devtools_http_handler.h b/content/public/browser/devtools_http_handler.h
index db0a9983001de390194bb7ba994d72c6be16d0bb..cdd099a022c06932c15b0268395003f8e8dd2e69 100644
--- a/content/public/browser/devtools_http_handler.h
+++ b/content/public/browser/devtools_http_handler.h
@@ -11,6 +11,7 @@
#include "content/common/content_export.h"
namespace net {
+class StreamListenSocketFactory;
class URLRequestContextGetter;
}
@@ -41,11 +42,10 @@ class DevToolsHttpHandler {
CONTENT_EXPORT static int GetFrontendResourceId(
const std::string& name);
- // Takes ownership over |delegate|.
+ // Takes ownership over |socket_factory| and |delegate|.
CONTENT_EXPORT static DevToolsHttpHandler* Start(
- const std::string& ip,
- int port,
const std::string& frontend_url,
+ net::StreamListenSocketFactory* socket_factory,
net::URLRequestContextGetter* request_context_getter,
DevToolsHttpHandlerDelegate* delegate);

Powered by Google App Engine
This is Rietveld 408576698