Decouple DevTools from socket implementation.

net/base/tcp_listen_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_TCP_LISTEN_SOCKET_H_
 #define NET_BASE_TCP_LISTEN_SOCKET_H_
 #pragma once
 
 #include <string>
 
@@ skipping 21 matching lines @@
 
   static SOCKET CreateAndBind(const std::string& ip, int port);
 
   // Implements StreamListenSocket::Accept.
   virtual void Accept() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TCPListenSocket);
 };
 
+// Factory that can be used to instantiate TCPListenSocket.
+class TCPListenSocketFactory : public StreamListenSocketFactory {
+public:

[pfeldman, 2012/05/14 11:12:00]

space before public.

[Philippe, 2012/05/14 12:36:52]

Done.

+  TCPListenSocketFactory(const std::string& ip, int port);
+  virtual ~TCPListenSocketFactory();
+
+  // Returns a new instance of TCPListenSocket created through

[pfeldman, 2012/05/14 11:12:00]

Should be // StreamListenSocketFactory overrides

[Philippe, 2012/05/14 12:36:52]

Done.

+  // TCPListenSocket::CreateAndListen().
+  virtual scoped_refptr<StreamListenSocket> CreateAndListen(
+      StreamListenSocket::Delegate* delegate) OVERRIDE;
+
+private:
+  const std::string ip_;

[pfeldman, 2012/05/14 11:12:00]

DISALLOW_COPY_AND_ASSIGN is missing

[Philippe, 2012/05/14 12:36:52]

I added it although there is nothing here that prevents this class from being
copied.

[mmenke, 2012/05/14 20:45:19]

Copying classes with inheritance scares me.

[Philippe, 2012/05/15 14:39:09]

That's a good point.

+  const int port_;
+};
+
 }  // namespace net
 
 #endif  // NET_BASE_TCP_LISTEN_SOCKET_H_