Decouple DevTools from socket implementation.

net/server/http_server.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SERVER_HTTP_SERVER_H_
 #define NET_SERVER_HTTP_SERVER_H_
 #pragma once
 
 #include <list>
 #include <map>
@@ skipping 21 matching lines @@
 
     virtual void OnWebSocketMessage(int connection_id,
                                     const std::string& data) = 0;
 
     virtual void OnClose(int connection_id) = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
-  HttpServer(const std::string& host, int port, HttpServer::Delegate* del);
+  HttpServer(HttpServer::Delegate* delegate,
+             StreamListenSocketFactory* socket_factory);

[mmenke, 2012/05/14 20:45:19]

Think the factory could actually be:

const StreamListenSocketFactory& socket_factory.

Advantage of that is it makes clear it can't be NULL, and we don't take
ownership.  Should also probably be the first parameter, since we don't mutate
it.

[Philippe, 2012/05/15 14:39:09]

Indeed. For the other places where we take ownership, I made it a const pointer.

 
   void AcceptWebSocket(int connection_id,
                        const HttpServerRequestInfo& request);
   void SendOverWebSocket(int connection_id, const std::string& data);
   void Send(int connection_id, const std::string& data);
   void Send(int connection_id, const char* bytes, int len);
   void Send200(int connection_id,
                const std::string& data,
                const std::string& mime_type);
   void Send404(int connection_id);
@@ skipping 31 matching lines @@
   IdToConnectionMap id_to_connection_;
   typedef std::map<StreamListenSocket*, HttpConnection*> SocketToConnectionMap;
   SocketToConnectionMap socket_to_connection_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpServer);
 };
 
 }  // namespace net
 
 #endif // NET_SERVER_HTTP_SERVER_H_