Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 10386033: Filter unwanted file types from editor text search scope. (Closed)

Created:
8 years, 7 months ago by pquitslund
Modified:
8 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Filter unwanted file types from editor text search scope. Specifically: remove dart-sdk/lib/config/ contents and .dart.js files from search scope. Committed: https://code.google.com/p/dart/source/detail?r=7427

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Messages

Total messages: 3 (0 generated)
pquitslund
8 years, 7 months ago (2012-05-08 18:31:34 UTC) #1
danrubel
lgtm https://chromiumcodereview.appspot.com/10386033/diff/7001/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java File editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java (right): https://chromiumcodereview.appspot.com/10386033/diff/7001/editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java#newcode59 editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java:59: public static boolean isFiltered(String fileName) { I recommend ...
8 years, 7 months ago (2012-05-08 18:38:20 UTC) #2
pquitslund
8 years, 7 months ago (2012-05-08 18:42:24 UTC) #3
On 2012/05/08 18:38:20, danrubel wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10386033/diff/7001/editor/tools/plugin...
> File
>
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/10386033/diff/7001/editor/tools/plugin...
>
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/ui/text/TextSearchScopeFilter.java:59:
> public static boolean isFiltered(String fileName) {
> I recommend making this method private seeing as it only provides a partial
> answer for "is this filtered" and external callers should be calling one of
the
> two methods above rather than this method.

Done!

Powered by Google App Engine
This is Rietveld 408576698