Prevent title-only panel from fully minimizing when attention is cleared if mouse is in the panel o…

chrome/browser/ui/panels/panel_drag_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/detached_panel_strip.h"
 #include "chrome/browser/ui/panels/docked_panel_strip.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_drag_controller.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
+#include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
 
 class PanelDragBrowserTest : public BasePanelBrowserTest {
  public:
   PanelDragBrowserTest() : BasePanelBrowserTest() {
   }
 
   virtual ~PanelDragBrowserTest() {
   }
 
   virtual void SetUpOnMainThread() OVERRIDE {
@@ skipping 370 matching lines @@
   EXPECT_EQ(mouse_location, panel3->GetBounds().origin());
 
   panel3_testing->CancelDragTitlebar();
   EXPECT_EQ(position2, panel1->GetBounds().origin());
   EXPECT_EQ(position3, panel2->GetBounds().origin());
   EXPECT_EQ(position1, panel3->GetBounds().origin());
 
   PanelManager::GetInstance()->CloseAll();
 }
 
+IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, DragMinimizedPanel) {
+  // We'll simulate mouse movements for test.
+  PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
+  PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
+
+  Panel* panel = CreatePanel("panel1");
+  scoped_ptr<NativePanelTesting> panel_testing(
+      NativePanelTesting::Create(panel->native_panel()));
+
+  panel->Minimize();
+  EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+
+  // Hover over minimized panel to bring up titlebar.
+  gfx::Point hover_point(panel->GetBounds().origin());
+  MoveMouseAndWaitForExpansionStateChange(panel, hover_point);
+  EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+
+  // Verify we can drag a minimized panel.
+  gfx::Rect panel_old_bounds = panel->GetBounds();
+  gfx::Point mouse_location = panel_old_bounds.origin();
+  panel_testing->PressLeftMouseButtonTitlebar(mouse_location);
+  EXPECT_EQ(panel_old_bounds, panel->GetBounds());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+
+  mouse_location.Offset(-70, 0);
+  panel_testing->DragTitlebar(mouse_location);
+  gfx::Rect panel_new_bounds = panel_old_bounds;
+  panel_new_bounds.Offset(-70, 0);
+  EXPECT_EQ(panel_new_bounds, panel->GetBounds());

[jianli, 2012/05/15 22:59:47]

Can you also verify that panel is still in title-only state?

[jennb, 2012/05/16 00:47:09]

Done.

+
+  // Verify panel returns to fully minimized state after dragging ends.
+  panel_testing->FinishDragTitlebar();
+  MoveMouseAndWaitForExpansionStateChange(panel, mouse_location);
+  EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());

[jianli, 2012/05/15 22:59:47]

Can we have a test that we're dragging a title-only panel at the middle position
of the titlebar and the panel is still title-only when we release the mouse?

[jennb, 2012/05/16 00:47:09]

Added check after FinishDragTitlebar() to verify title-only mode is still in
effect. That covers what you're asking for because mouse-release does not end
title-only mode; panel stays in title-only mode until mouse moves away from
panel.

+
+  panel->Close();
+}
+
+IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, DragMinimizedDrawAttentionPanel) {

[jianli, 2012/05/15 22:59:47]

DragMinimizedDrawAttentionPanel => DragMinimizedDrawnAttentionPanel or
DragMinimizedPanelOnAttention

[jennb, 2012/05/16 00:47:09]

DragMinimizedPanelWhileDrawingAttention

+  // We'll simulate mouse movements for test.
+  PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
+  PanelManager::GetInstance()->SetMouseWatcherForTesting(mouse_watcher);
+
+  Panel* panel = CreatePanel("panel1");
+  scoped_ptr<NativePanelTesting> panel_testing(
+      NativePanelTesting::Create(panel->native_panel()));
+
+  panel->Minimize();
+  EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+
+  panel->FlashFrame(true);
+  EXPECT_TRUE(panel->IsDrawingAttention());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+
+  // Drag the panel. Verify panel stays in title-only state after attention is
+  // cleared because it is being dragged.
+  gfx::Rect panel_old_bounds = panel->GetBounds();
+  gfx::Point mouse_location = panel_old_bounds.origin();
+  panel_testing->PressLeftMouseButtonTitlebar(mouse_location);
+  EXPECT_EQ(panel_old_bounds, panel->GetBounds());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+
+  mouse_location.Offset(-70, 0);
+  panel_testing->DragTitlebar(mouse_location);
+  gfx::Rect panel_new_bounds = panel_old_bounds;
+  panel_new_bounds.Offset(-70, 0);
+  EXPECT_EQ(panel_new_bounds, panel->GetBounds());
+
+  panel->FlashFrame(false);
+  EXPECT_FALSE(panel->IsDrawingAttention());
+  EXPECT_EQ(Panel::TITLE_ONLY, panel->expansion_state());
+
+  // Verify panel returns to fully minimized state after dragging ends.
+  panel_testing->FinishDragTitlebar();
+  MoveMouseAndWaitForExpansionStateChange(panel, mouse_location);
+  EXPECT_EQ(Panel::MINIMIZED, panel->expansion_state());
+
+  panel->Close();
+}
+
 IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, CloseDockedPanelOnDrag) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   PanelDragController* drag_controller = panel_manager->drag_controller();
   DockedPanelStrip* docked_strip = panel_manager->docked_strip();
 
   // Create 4 docked panels.
   // We have:  P4  P3  P2  P1
   Panel* panel1 = CreatePanelWithBounds("Panel1", gfx::Rect(0, 0, 100, 100));
   Panel* panel2 = CreatePanelWithBounds("Panel2", gfx::Rect(0, 0, 100, 100));
   Panel* panel3 = CreatePanelWithBounds("Panel3", gfx::Rect(0, 0, 100, 100));
@@ skipping 802 matching lines @@
   EXPECT_EQ(PanelStrip::DOCKED, panel1->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel2->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel3->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel4->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel5->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel6->panel_strip()->type());
   EXPECT_EQ(PanelStrip::DOCKED, panel7->panel_strip()->type());
 
   panel_manager->CloseAll();
 }