Adding protobuf headers that will be used by upcoming continuous speech recognition classes (Speech…

content/browser/speech/proto/google_streaming_api.proto

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+syntax = "proto2";
+option optimize_for = LITE_RUNTIME;
+
+//option cc_api_version = 2;
+//option java_api_version = 2;

[hans, 2012/05/16 10:42:47]

should these two commented out lines be here?

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Done.

+
+package speech;
+
+// ==================================================================
+// Messages sent to client.

[hans, 2012/05/16 10:42:47]

not sure how helpful this comment is?

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Right.

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Agree, removed.

+// ==================================================================
+
+// All responses must be an extension of this message.

[hans, 2012/05/16 10:42:47]

hmm, but this this seems to be the only response message that gets defined?

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Agree. removed.

+message HttpStreamingResult {
+  optional int32 status = 1;
+  // Required.  The request_id of the RecognitionRequest that

[hans, 2012/05/16 10:42:47]

if it's required, why is it marked optional?

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Ha. To be honest either its purpose is not completely clear to me. Added a TODO.

+  // initiated the sequence associated with this response.
+  optional int32 id = 2;
+  repeated HttpStreamingHypothesis hypotheses = 3;
+
+  optional string provisional = 4;

[hans, 2012/05/16 10:42:47]

could we try to comment this file a bit more extensively? maybe look for
inspiration in sync/protocol/sync.proto which is very nicely commented.

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Done.

+  optional string ephemeral = 5;
+
+  optional string upstream_url = 6;
+  optional bool upstream_connected = 7;
+}
+
+message HttpStreamingHypothesis {
+  // Hypothesis as text.
+  optional string utterance = 1;

[hans, 2012/05/16 10:42:47]

i like a blank line between fields when they have comments, to make it easier to
read and more obvious which field a comment belongs to

[Primiano Tucci (use gerrit), 2012/05/16 13:34:19]

Done.

+  // Field below is typically provided only for the top hypothesis.
+  // Confidence score associated with this hypothesis.
+  optional float confidence = 2;
+}