When converting -m/--message to -t, make sure to handle the case --message=foo

gcl.py

Index: gcl.py
===================================================================
--- gcl.py	(revision 136864)
+++ gcl.py	(working copy)
@@ -825,9 +825,15 @@
   if FilterFlag(args, "--send-mail"):
     args.append("--send_mail")
 
-  # Replace -m or --message with -t.
-  args = map(lambda a: '-t' if (a == '-m' or a == '--message') else a, args)
-  
+  # Replace -m with -t.  Replace --message with --title, but make sure to
+  # preserve anything after the --message.
+  def replace_message(a):
+    if a == '-m':

[M-A Ruel, 2012/05/14 14:17:39]

Note that

gcl upload foo -mbleh
works.

[Roger Tawa OOO till Jul 10th, 2012/05/14 16:09:50]

Didn't know that, fixed.

+      return '-t'
+    elif a.startswith('--message'):
+      return '--title' + a[9:]
+    return a
+  args = map(replace_message, args)

[M-A Ruel, 2012/05/14 14:17:39]

What about printing out a warning message when one of the condition triggers?
print 'Warning, you must start using -t instead of -m. -m will post a message
unconditionally.'
or
'See FAQ at <url>'
or whatever so devs can learn on the go.

[Roger Tawa OOO till Jul 10th, 2012/05/14 16:09:50]

Yes, good idea. Done.

 
   upload_arg = ["upload.py", "-y"]
   upload_arg.append("--server=%s" % change_info.rietveld)