views: Have a more accurate name for View parent_owned accessors.

ui/views/view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_VIEW_H_
 #define UI_VIEWS_VIEW_H_
 #pragma once
 
 #include <algorithm>
 #include <map>
@@ skipping 100 matching lines @@
   // TODO(beng): delete
   // Returns whether the view is hot-tracked.
   virtual bool IsHotTracked() const;
 
   // Creation and lifetime -----------------------------------------------------
 
   View();
   virtual ~View();
 
   // By default a View is owned by its parent unless specified otherwise here.
-  bool parent_owned() const { return parent_owned_; }
-  void set_parent_owned(bool parent_owned) { parent_owned_ = parent_owned; }
+  bool owned_by_parent() const { return owned_by_parent_; }

[Ben Goodger (Google), 2012/05/10 16:51:20]

is this accessor used by anyone outside of View? seems like it could be
unnecessary.

+  void set_not_owned_by_parent() { owned_by_parent_ = false; }

[Ben Goodger (Google), 2012/05/10 16:51:20]

this function name feels awkward to me (though so did the old one).

there are really two modes of ownership:

- hierarchy (specifically, the parent views::View)
- client code (code that uses views)

Perhaps this could be set_owned_by_client().

 
   // Tree operations -----------------------------------------------------------
 
   // Get the Widget that hosts this View, if any.
   virtual const Widget* GetWidget() const;
   virtual Widget* GetWidget();
 
   // Adds |view| as a child of this view, optionally at |index|.
   void AddChildView(View* view);
   void AddChildViewAt(View* view, int index);
@@ skipping 1192 matching lines @@
   // Starts a drag and drop operation originating from this view. This invokes
   // WriteDragData to write the data and GetDragOperations to determine the
   // supported drag operations. When done, OnDragDone is invoked. |press_pt| is
   // in the view's coordinate system.
   void DoDrag(const LocatedEvent& event, const gfx::Point& press_pt);
 
   //////////////////////////////////////////////////////////////////////////////
 
   // Creation and lifetime -----------------------------------------------------
 
-  // True if the hierarchy (i.e. the parent View) is responsible for deleting
-  // this View. Default is true.
-  bool parent_owned_;
+  // True if this views is owned by its parent - i.e. it will be deleted by its
+  // parent during its parents destruction. True is the default.
+  bool owned_by_parent_;
 
   // Attributes ----------------------------------------------------------------
 
   // The id of this View. Used to find this View.
   int id_;
 
   // The group of this view. Some view subclasses use this id to find other
   // views of the same group. For example radio button uses this information
   // to find other radio buttons.
   int group_;
@@ skipping 123 matching lines @@
   base::win::ScopedComPtr<NativeViewAccessibilityWin>
       native_view_accessibility_win_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(View);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_VIEW_H_