Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 10383302: Move dart:dom implementation classes to dart:html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index 4dc4adcdab672a04350ff3292e026c544a08dc14..f3a9dad800c6a99011aaa296b54f331bd436d00a 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -1152,7 +1152,8 @@ class HtmlFrogSystem(HtmlSystem):
class HtmlDartiumSystem(HtmlSystem):
- def __init__(self, templates, database, emitters, auxiliary_dir, output_dir):
+ def __init__(self, templates, database, emitters, auxiliary_dir,
+ dom_implementation_classes, output_dir):
"""Prepared for generating wrapping implementation.
- Creates emitter for Dart code.
@@ -1160,6 +1161,7 @@ class HtmlDartiumSystem(HtmlSystem):
super(HtmlDartiumSystem, self).__init__(
templates, database, emitters, output_dir)
self._auxiliary_dir = auxiliary_dir
+ self._dom_implementation_classes = dom_implementation_classes
self._shared = HtmlSystemShared(database)
self._dart_dartium_file_paths = []
self._wrap_cases = []
@@ -1199,8 +1201,8 @@ class HtmlDartiumSystem(HtmlSystem):
os.path.join(self._output_dir, 'html_dartium.dart'),
(self._interface_system._dart_interface_file_paths +
self._interface_system._dart_callback_file_paths +
- self._dart_dartium_file_paths
- ),
+ self._dart_dartium_file_paths +
+ self._dom_implementation_classes),
AUXILIARY_DIR=MassagePath(auxiliary_dir),
WRAPCASES='\n'.join(self._wrap_cases))
@@ -1341,7 +1343,8 @@ class HtmlDartiumInterfaceGenerator(object):
emitter.Emit(
template,
FACTORYPROVIDER=factory_provider,
- CONSTRUCTOR=interface_name,
+ INTERFACE=interface_name,
+ DOM_INTERFACE=self._interface.javascript_binding_name,
PARAMETERS=constructor_info.ParametersImplementationDeclaration(),
NAMED_CONSTRUCTOR=constructor_info.name or interface_name,
ARGUMENTS=self._UnwrappedParameters(constructor_info,

Powered by Google App Engine
This is Rietveld 408576698