Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: lib/dom/templates/html/dartium/impl_EventTarget.darttemplate

Issue 10383302: Move dart:dom implementation classes to dart:html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/dartium/impl_EventTarget.darttemplate
diff --git a/lib/dom/templates/html/dartium/impl_EventTarget.darttemplate b/lib/dom/templates/html/dartium/impl_EventTarget.darttemplate
index 18b73540d74f0d719c2ffc14627cebb2d557efb4..2bccec321537dbeb6c03ea55b9ddcdd68ad34a9e 100644
--- a/lib/dom/templates/html/dartium/impl_EventTarget.darttemplate
+++ b/lib/dom/templates/html/dartium/impl_EventTarget.darttemplate
@@ -3,15 +3,15 @@
// BSD-style license that can be found in the LICENSE file.
class _EventsImpl implements Events {
-
- final _EventTargetImpl _ptr;
+ // TODO(podivilov): add type.
+ final _ptr;
final Map<String, EventListenerList> _listenerMap;
_EventsImpl(this._ptr) : _listenerMap = <EventListenerList>{};
EventListenerList operator [](String type) {
- return _get(type.toLowerCase());
+ return _get(type);
Anton Muhin 2012/05/23 14:03:31 why this change?
podivilov 2012/05/23 14:52:40 It was a bug that prevented access to non lowercas
Anton Muhin 2012/05/23 15:25:23 please, a separate CL. On 2012/05/23 14:52:40, po
podivilov 2012/05/24 10:33:07 Done.
}
EventListenerList _get(String type) {
@@ -28,7 +28,8 @@ class _EventListenerWrapper {
}
class _EventListenerListImpl implements EventListenerList {
- final _EventTargetImpl _ptr;
+ // TODO(podivilov): add type.
+ final _ptr;
final String _type;
List<_EventListenerWrapper> _wrappers;
@@ -50,11 +51,11 @@ class _EventListenerListImpl implements EventListenerList {
// TODO(jacobr): what is the correct behavior here. We could alternately
// force the event to have the expected type.
assert(evt.type == _type);
- return _ptr.$dom_dispatchEvent(evt);
+ return _ptr.dispatchEvent(_unwrap(evt));
}
void _add(EventListener listener, bool useCapture) {
- _ptr.$dom_addEventListener(_type,
+ _ptr.addEventListener(_type,
_findOrAddWrapper(listener, useCapture),
useCapture);
}
@@ -62,7 +63,7 @@ class _EventListenerListImpl implements EventListenerList {
void _remove(EventListener listener, bool useCapture) {
Function wrapper = _removeWrapper(listener, useCapture);
if (wrapper !== null) {
- _ptr.$dom_removeEventListener(_type, wrapper, useCapture);
+ _ptr.removeEventListener(_type, wrapper, useCapture);
}
}

Powered by Google App Engine
This is Rietveld 408576698