ui/base/keycodes/keyboard_code_conversion_x.cc - Issue 10383301: Move modifier remapping code from X to Ash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/keycodes/keyboard_code_conversion_x.cc

Issue 10383301: Move modifier remapping code from X to Ash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/keycodes/keyboard_code_conversion_x.cc

diff --git a/ui/base/keycodes/keyboard_code_conversion_x.cc b/ui/base/keycodes/keyboard_code_conversion_x.cc

index 1e3209008382b034d5d8900011e2f067815ec974..3808f4605330d65ae2cd66f65288aeac5ddead4d 100644

--- a/ui/base/keycodes/keyboard_code_conversion_x.cc

+++ b/ui/base/keycodes/keyboard_code_conversion_x.cc

@@ -365,7 +365,8 @@ KeyboardCode KeyboardCodeFromXKeysym(unsigned int keysym) {

// TODO(sad): some keycodes are still missing.

}

- DLOG(WARNING) << "Unknown keysym: " << StringPrintf("0x%x", keysym);

+ if (keysym)

+ DLOG(WARNING) << "Unknown keysym: " << StringPrintf("0x%x", keysym);

return VKEY_UNKNOWN;

}