Move RegisterContentSchemes from public url_constants into non-public url_schemes.

content/public/common/url_constants.h

Index: content/public/common/url_constants.h
diff --git a/content/public/common/url_constants.h b/content/public/common/url_constants.h
index a6e7567cf67b96d6527c5bde00bf05daea14db38..cbf30dd385b4525b27a514683b283bc8537e8e35 100644
--- a/content/public/common/url_constants.h
+++ b/content/public/common/url_constants.h
@@ -67,19 +67,7 @@ extern const char kSwappedOutURL[];
 
 // Null terminated list of schemes that are savable. This function can be
 // invoked on any thread.
-CONTENT_EXPORT const char** GetSavableSchemes();
-
-// Note: ContentMainRunner calls this method internally as part of main
-// initialziation, so this function generally should not be called by
-// embedders. It's exported to facilitate test harnesses that do not
-// utilize ContentMainRunner and that do not wish to lock the set
-// of standard schemes at init time.
-//
-// Called near the beginning of startup to register URL schemes that should
-// be parsed as "standard" with the googleurl library. Optionally, the set
-// of standard schemes is locked down. The embedder can add additional
-// schemes by overriding the ContentClient::AddAdditionalSchemes method.
-CONTENT_EXPORT void RegisterContentSchemes(bool lock_standard_schemes);
+CONTENT_EXPORT const char* const* GetSavableSchemes();

[grt (UTC plus 2), 2012/05/24 19:29:21]

The double const is the right thing (callers shouldn't be permitted to modify
the strings or the array itself).  I've created
https://chromiumcodereview.appspot.com/10445025/ to fix the recipient in
src/webkit and remove the cast I'm adding here to render_view_impl.  (Note that
although the cast removal is present in my local branch, it doesn't appear in
the CL since the cast itself isn't present in ToT.)

Does this work for you?

[jam, 2012/05/24 19:49:26]

I understand why you're doing this. it just makes readability harder imo. but i
don't feel strongly about this since it's technically more correct.

[grt (UTC plus 2), 2012/05/24 20:33:14]

I guess I'm on the other side of the readability fence.  The previous code made
me spend extra time thinking about why the array wasn't const, why there were
two const_casts, and why kDefaultSavableSchemes wasn't actually a constant.

 
 }  // namespace content