Make AssociateWithRenderView() a free function in the 'content' namespace

content/public/common/url_fetcher.h

Index: content/public/common/url_fetcher.h
diff --git a/content/public/common/url_fetcher.h b/content/public/common/url_fetcher.h
index 1c9469e13b339b4d8cc20e8e1fe15bd40a4ff910..c39ba07f121f167fe0c02a43af3a20ef073ae94d 100644
--- a/content/public/common/url_fetcher.h
+++ b/content/public/common/url_fetcher.h
@@ -13,14 +13,10 @@ namespace content {
 
 class URLFetcherDelegate;
 
-// Extend net::URLFetcher to add content-specific methods.
-//
-// TODO(akalin): Move some more content-specific methods from
-// net::URLFetcher.
+// TODO(akalin): Move the static functions to net::URLFetcher and
+// remove content::URLFetcher.
 class CONTENT_EXPORT URLFetcher : public net::URLFetcher {
  public:
-  // TODO(akalin): Move the static functions to net::URLFetcher.
-
   // |url| is the URL to send the request to.
   // |request_type| is the type of request to make.
   // |d| the object that will receive the callback on fetch completion.
@@ -48,14 +44,16 @@ class CONTENT_EXPORT URLFetcher : public net::URLFetcher {
   // to enable it for tests. Also see ScopedURLFetcherFactory for another way
   // of testing code that uses an URLFetcher.
   static void SetEnableInterceptionForTests(bool enabled);
-
-  // Mark URLRequests started by the URLFetcher to stem from the given render
-  // view.
-  virtual void AssociateWithRenderView(const GURL& first_party_for_cookies,
-                                       int render_process_id,
-                                       int render_view_id) = 0;
 };
 
+// Mark URLRequests started by the URLFetcher to stem from the given render
+// view.
+void CONTENT_EXPORT AssociateWithRenderView(

[jam, 2012/05/21 21:39:19]

nit: convention is CONTENT_EXPORT void

since this is now outside a class, make the static function's name clearer. i.e.
AssociateURLFetcherWithRenderView

[akalin, 2012/05/21 22:28:37]

Done.

+    net::URLFetcher* url_fetcher,
+    const GURL& first_party_for_cookies,
+    int render_process_id,
+    int render_view_id);
+
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_URL_FETCHER_H_