Make AssociateWithRenderView() a free function in the 'content' namespace

net/url_request/url_fetcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_FETCHER_H_
 #define NET_URL_REQUEST_URL_FETCHER_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
+#include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/platform_file.h"
+#include "base/supports_user_data.h"
 #include "net/base/net_export.h"
 
 class FilePath;
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 class TimeDelta;
 }
 
@@ skipping 44 matching lines @@
 
   enum RequestType {
     GET,
     POST,
     HEAD,
     DELETE_REQUEST,   // DELETE is already taken on Windows.
                       // <winnt.h> defines a DELETE macro.
     PUT,
   };
 
+  // Used by SetURLRequestUserData.  The callback should make a fresh
+  // Data* object every time it's called.

[wtc, 2012/05/21 22:16:48]

Nit: perhaps remove the '*' after "Data"?  "Data*" implies a
pointer rather than an object.

It would be clearer to fully qualify base::SupportsUserData::Data.

[akalin, 2012/05/21 22:28:37]

Done.

+  typedef base::Callback<base::SupportsUserData::Data*()> CreateDataCallback;
+
   virtual ~URLFetcher();
 
   // Sets data only needed by POSTs.  All callers making POST requests should
   // call this before the request is started.  |upload_content_type| is the MIME
   // type of the content, while |upload_content| is the data to be sent (the
   // Content-Length header value will be set to the length of this data).
   virtual void SetUploadData(const std::string& upload_content_type,
                              const std::string& upload_content) = 0;
 
   // Indicates that the POST data is sent via chunked transfer encoding.
@@ skipping 30 matching lines @@
   virtual void AddExtraRequestHeader(const std::string& header_line) = 0;
 
   virtual void GetExtraRequestHeaders(
       HttpRequestHeaders* headers) const = 0;
 
   // Set the URLRequestContext on the request.  Must be called before the
   // request is started.
   virtual void SetRequestContext(
       URLRequestContextGetter* request_context_getter) = 0;
 
+  virtual void SetFirstPartyForCookies(

[wtc, 2012/05/21 22:16:48]

Can you copy the comment (or add it) for this method?

[akalin, 2012/05/21 22:28:37]

Done.  Also updated URLFetcherCore docs.

+      const GURL& first_party_for_cookies) = 0;
+
+  // Whenever a URLRequest object is created, SetUserData() will be

[wtc, 2012/05/21 22:16:48]

Is SetUserData a typo?  This method is named SetURLRequestUserData.
Ah, I think I see what you mean.  This comment is a little
confusing.  I think we should add a one-sentence description
of what SetURLRequestUserData does.

[akalin, 2012/05/21 22:28:37]

This *is* supposed to be the one-sentence description, but apparently it's not
clear.  Rewrote it to hopefully be clearer.

+  // called on it with the given key and the result of the given
+  // callback.
+  virtual void SetURLRequestUserData(
+      const void* key, const CreateDataCallback& create_data_callback) = 0;
+
   // If |retry| is false, 5xx responses will be propagated to the observer,
   // if it is true URLFetcher will automatically re-execute the request,
   // after backoff_delay() elapses. URLFetcher has it set to true by default.
   virtual void SetAutomaticallyRetryOn5xx(bool retry) = 0;
 
   virtual void SetMaxRetries(int max_retries) = 0;
   virtual int GetMaxRetries() const = 0;
 
   // Returns the back-off delay before the request will be retried,
   // when a 5xx response was received.
@@ skipping 69 matching lines @@
   // true, caller takes responsibility for the file, and it will not
   // be removed once the URLFetcher is destroyed.  User should not take
   // ownership more than once, or call this method after taking ownership.
   virtual bool GetResponseAsFilePath(bool take_ownership,
                                      FilePath* out_response_path) const = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_FETCHER_H_