content/common/gpu/gpu_command_buffer_stub.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_command_buffer_stub.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make win bot happy Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/gpu_command_buffer_stub.h

diff --git a/content/common/gpu/gpu_command_buffer_stub.h b/content/common/gpu/gpu_command_buffer_stub.h

index eeb3c9b00d95a8701ea80da4ae7d48286a492365..aa30711778f39c10a2121a6c4108c5c39ffa7c9c 100644

--- a/content/common/gpu/gpu_command_buffer_stub.h

+++ b/content/common/gpu/gpu_command_buffer_stub.h

@@ -83,10 +83,11 @@ class GpuCommandBufferStub

public:

class DestructionObserver {

public:

- ~DestructionObserver() {}

// Called in Destroy(), before the context/surface are released.

virtual void OnWillDestroyStub(GpuCommandBufferStub* stub) = 0;

+ protected:

+ virtual ~DestructionObserver() {}

};

GpuCommandBufferStub(