content/browser/ssl/ssl_error_handler.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/ssl/ssl_error_handler.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make win bot happy Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/ssl/ssl_error_handler.h

diff --git a/content/browser/ssl/ssl_error_handler.h b/content/browser/ssl/ssl_error_handler.h

index 3063d1669d3d50aedbd7074bea8d5d85bb621103..a84f9fda9cf2ea54844e46f354e37e396306ea14 100644

--- a/content/browser/ssl/ssl_error_handler.h

+++ b/content/browser/ssl/ssl_error_handler.h

@@ -60,6 +60,9 @@ class SSLErrorHandler : public base::RefCountedThreadSafe<SSLErrorHandler> {

// Called when SSLErrorHandler decides to continue the request despite the

// SSL error.

virtual void ContinueSSLRequest(const content::GlobalRequestID& id) = 0;

+ protected:

+ virtual ~Delegate() {}

};

virtual SSLCertErrorHandler* AsSSLCertErrorHandler();