chrome/browser/extensions/bundle_installer.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bundle_installer.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make win bot happy Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/bundle_installer.h

diff --git a/chrome/browser/extensions/bundle_installer.h b/chrome/browser/extensions/bundle_installer.h

index 05262a98714542055b10d7de79a59424d2de3222..655d3fa3d9c284405c9a87b0d539038a8eb70372 100644

--- a/chrome/browser/extensions/bundle_installer.h

+++ b/chrome/browser/extensions/bundle_installer.h

@@ -51,6 +51,9 @@ class BundleInstaller : public WebstoreInstallHelper::Delegate,

virtual void OnBundleInstallApproved() {}

virtual void OnBundleInstallCanceled(bool user_initiated) {}

virtual void OnBundleInstallCompleted() {}

+ protected:

+ virtual ~Delegate() {}

};

// Represents an individual member of the bundle.