Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: media/base/demuxer.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/demuxer.h
diff --git a/media/base/demuxer.h b/media/base/demuxer.h
index a8cf50b9f003df63f3d76adab967c395fc73a000..55eb31e2665d07220d7b00523e2143dd73f0a882 100644
--- a/media/base/demuxer.h
+++ b/media/base/demuxer.h
@@ -16,8 +16,6 @@ namespace media {
class MEDIA_EXPORT DemuxerHost : public DataSourceHost {
public:
- virtual ~DemuxerHost();
-
// Get the duration of the media in microseconds. If the duration has not
// been determined yet, then returns 0.
virtual void SetDuration(base::TimeDelta duration) = 0;
@@ -28,6 +26,9 @@ class MEDIA_EXPORT DemuxerHost : public DataSourceHost {
// Stops execution of the pipeline due to a fatal error. Do not call this
// method with PIPELINE_OK.
virtual void OnDemuxerError(PipelineStatus error) = 0;
+
+ protected:
+ virtual ~DemuxerHost();
};
class MEDIA_EXPORT Demuxer : public base::RefCountedThreadSafe<Demuxer> {

Powered by Google App Engine
This is Rietveld 408576698