Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: ipc/ipc_channel.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index 2aeca1fceda3a79ee34e080fb60e2487e404203e..b2742e604fb2006d68fa019667f910ac6d999641 100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -40,8 +40,6 @@ class IPC_EXPORT Channel : public Message::Sender {
// Implemented by consumers of a Channel to receive messages.
class IPC_EXPORT Listener {
public:
- virtual ~Listener() {}
-
// Called when a message is received. Returns true iff the message was
// handled.
virtual bool OnMessageReceived(const Message& message) = 0;
@@ -63,6 +61,9 @@ class IPC_EXPORT Channel : public Message::Sender {
// has an error that causes the listening channel to close.
virtual void OnChannelListenError() {}
#endif // OS_POSIX
+
+ protected:
+ virtual ~Listener() {}
};
// Flags to test modes

Powered by Google App Engine
This is Rietveld 408576698