Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: content/public/browser/download_manager_delegate.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_manager_delegate.h
diff --git a/content/public/browser/download_manager_delegate.h b/content/public/browser/download_manager_delegate.h
index 21b09024eab94e7c662ff381b7b0ada793f71faa..a6ed4573d0b9dffdfe9bd04487c39f6b391c3ca9 100644
--- a/content/public/browser/download_manager_delegate.h
+++ b/content/public/browser/download_manager_delegate.h
@@ -36,8 +36,6 @@ typedef base::Callback<void(const FilePath&,
// Browser's download manager: manages all downloads and destination view.
class CONTENT_EXPORT DownloadManagerDelegate {
public:
- virtual ~DownloadManagerDelegate();
-
// Lets the delegate know that the download manager is shutting down.
virtual void Shutdown() {}
@@ -130,6 +128,9 @@ class CONTENT_EXPORT DownloadManagerDelegate {
bool can_save_as_complete,
const SavePackagePathPickedCallback& callback) {
}
+
+ protected:
+ virtual ~DownloadManagerDelegate();
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698