Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: content/browser/download/download_item_impl.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.h
diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h
index 1bcdcd43490117b36c119b764de75d0601d34743..31b4a4c708f83702f893a4c4368dead37a3f2009 100644
--- a/content/browser/download/download_item_impl.h
+++ b/content/browser/download/download_item_impl.h
@@ -37,7 +37,6 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
class CONTENT_EXPORT Delegate {
public:
Delegate();
- virtual ~Delegate();
// Used for catching use-after-free errors.
void Attach();
@@ -73,6 +72,9 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {
// Assert consistent state for delgate object at various transitions.
virtual void AssertStateConsistent(DownloadItem* download) const = 0;
+ protected:
+ virtual ~Delegate();
+
private:
// For "Outlives attached DownloadItemImpl" invariant assertion.
int count_;

Powered by Google App Engine
This is Rietveld 408576698