Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5074)

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_url_fetcher.h
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h
index 202e035059c11d28af90f92ce94c3e0b30952b3f..58e57829fdfd9f8bb3afad499e70d144fa432b80 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.h
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h
@@ -41,7 +41,6 @@ class CloudPrintURLFetcher
class Delegate {
public:
- virtual ~Delegate() { }
// Override this to handle the raw response as it is available. No response
// error checking is done before this method is called. If the delegate
// returns CONTINUE_PROCESSING, we will then check for network
@@ -90,6 +89,9 @@ class CloudPrintURLFetcher
// Authentication information may change between retries.
// CloudPrintURLFetcher will request auth info before sending any request.
virtual std::string GetAuthHeader() = 0;
+
+ protected:
+ virtual ~Delegate() {}
};
CloudPrintURLFetcher();

Powered by Google App Engine
This is Rietveld 408576698