Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: chrome/browser/web_resource/notification_promo.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/notification_promo.h
diff --git a/chrome/browser/web_resource/notification_promo.h b/chrome/browser/web_resource/notification_promo.h
index de40cca3791f2e43ce9e85f0c8f7c49237a839f7..bdc1d89e828f296c119b2f90f2b2fe017dcce757 100644
--- a/chrome/browser/web_resource/notification_promo.h
+++ b/chrome/browser/web_resource/notification_promo.h
@@ -28,12 +28,14 @@ class NotificationPromo
public:
class Delegate {
public:
- virtual ~Delegate() {}
- virtual void OnNotificationParsed(double start, double end,
- bool new_notification) = 0;
- // For testing.
- virtual bool IsBuildAllowed(int builds_targeted) const { return false; }
- virtual int CurrentPlatform() const { return PLATFORM_NONE; }
+ virtual void OnNotificationParsed(double start, double end,
+ bool new_notification) = 0;
+ // For testing.
+ virtual bool IsBuildAllowed(int builds_targeted) const { return false; }
+ virtual int CurrentPlatform() const { return PLATFORM_NONE; }
+
+ protected:
+ virtual ~Delegate() {}
};
// Static factory for creating new notification promos.

Powered by Google App Engine
This is Rietveld 408576698