Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/policy/policy_service.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_service.h
diff --git a/chrome/browser/policy/policy_service.h b/chrome/browser/policy/policy_service.h
index 94f57aead76f39b97565051e4d58ad335fa4b39c..e2d28f0152ca802c53c668d1fcf226699b6217f1 100644
--- a/chrome/browser/policy/policy_service.h
+++ b/chrome/browser/policy/policy_service.h
@@ -36,8 +36,6 @@ class PolicyService {
public:
class Observer {
public:
- virtual ~Observer() {}
-
// Invoked whenever policies for the |domain|, |component_id| namespace are
// modified. This is only invoked for changes that happen after AddObserver
// is called. |previous| contains the values of the policies before the
@@ -51,6 +49,9 @@ class PolicyService {
// IsInitializationComplete() is false, then this will be invoked once all
// the policy providers are ready.
virtual void OnPolicyServiceInitialized() {}
+
+ protected:
+ virtual ~Observer() {}
};
virtual ~PolicyService() {}

Powered by Google App Engine
This is Rietveld 408576698