RefCounted types should not have public destructors, delegate cleanup

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 28 matching lines @@
     PLATFORM_FAILURE,
   };
 
   // Interface for collaborating with picture interface to provide memory for
   // output picture and blitting them.
   // This interface is extended by the various layers that relay messages back
   // to the plugin, through the PPP_VideoDecode_Dev interface the plugin
   // implements.
   class MEDIA_EXPORT Client {
    public:
-    virtual ~Client() {}
-
     // Callback to notify client that decoder has been initialized.
     virtual void NotifyInitializeDone() = 0;
 
     // Callback to tell client how many and what size of buffers to provide.
     virtual void ProvidePictureBuffers(
         uint32 requested_num_of_buffers, const gfx::Size& dimensions) = 0;
 
     // Callback to dismiss picture buffer that was assigned earlier.
     virtual void DismissPictureBuffer(int32 picture_buffer_id) = 0;
 
     // Callback to deliver decoded pictures ready to be displayed.
     virtual void PictureReady(const Picture& picture) = 0;
 
     // Callback to notify that decoded has decoded the end of the current
     // bitstream buffer.
     virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) = 0;
 
     // Flush completion callback.
     virtual void NotifyFlushDone() = 0;
 
     // Reset completion callback.
     virtual void NotifyResetDone() = 0;
 
     // Callback to notify about decoding errors.
     virtual void NotifyError(Error error) = 0;
+
+   protected:
+    virtual ~Client() {}
   };
 
   // Video decoder functions.
 
   // Initializes the video decoder with specific configuration.
   // Parameters:
   //  |profile| is the video stream's format profile.
   //
   // Returns true when command successfully accepted. Otherwise false.
   virtual bool Initialize(VideoCodecProfile profile) = 0;
@@ skipping 42 matching lines @@
   virtual void Destroy() = 0;
 
  protected:
   friend class base::RefCountedThreadSafe<VideoDecodeAccelerator>;
   virtual ~VideoDecodeAccelerator();
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_