RefCounted types should not have public destructors, delegate cleanup

media/filters/ffmpeg_glue.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // FFmpegGlue is an adapter for FFmpeg's URLProtocol interface that allows us to
 // use a DataSource implementation with FFmpeg.  For convenience we use FFmpeg's
 // avformat_open_input() function, which analyzes the filename given to it and
 // automatically initializes the appropriate URLProtocol.
 //
 // Since the DataSource is already open by time we call avformat_open_input(),
@@ skipping 23 matching lines @@
 #include "media/base/media_export.h"
 
 struct URLProtocol;
 
 namespace media {
 
 class MEDIA_EXPORT FFmpegURLProtocol {
  public:
   FFmpegURLProtocol() {}
 
-  virtual ~FFmpegURLProtocol() {}
-
   // Read the given amount of bytes into data, returns the number of bytes read
   // if successful, kReadError otherwise.
   virtual size_t Read(size_t size, uint8* data) = 0;
 
   // Returns true and the current file position for this file, false if the
   // file position could not be retrieved.
   virtual bool GetPosition(int64* position_out) = 0;
 
   // Returns true if the file position could be set, false otherwise.
   virtual bool SetPosition(int64 position) = 0;
 
   // Returns true and the file size, false if the file size could not be
   // retrieved.
   virtual bool GetSize(int64* size_out) = 0;
 
   // Returns false if this protocol supports random seeking.
   virtual bool IsStreaming() = 0;
 
+ protected:
+  virtual ~FFmpegURLProtocol() {}
+
  private:
   DISALLOW_COPY_AND_ASSIGN(FFmpegURLProtocol);
 };
 
 class MEDIA_EXPORT FFmpegGlue {
  public:
   // Returns the singleton instance.
   static FFmpegGlue* GetInstance();
 
   // Adds a FFmpegProtocol to the FFmpeg glue layer and returns a unique string
@@ skipping 28 matching lines @@
 
   friend class FFmpegGlueTest;
   static URLProtocol* url_protocol();
 
   DISALLOW_COPY_AND_ASSIGN(FFmpegGlue);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_FFMPEG_GLUE_H_