RefCounted types should not have public destructors, delegate cleanup

content/browser/device_orientation/provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_H_
 #define CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_H_
 
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 
 namespace device_orientation {
 
 class Orientation;
 
 class CONTENT_EXPORT Provider : public base::RefCountedThreadSafe<Provider> {
  public:
   class Observer {
    public:
     // Called when the orientation changes.
     // An Observer must not synchronously call Provider::RemoveObserver
     // or Provider::AddObserver when this is called.
     virtual void OnOrientationUpdate(const Orientation& orientation) = 0;
+
+   protected:
+    virtual ~Observer() {}
   };
 
   // Returns a pointer to the singleton instance of this class.
   // The caller should store the returned pointer in a scoped_refptr.
   // The Provider instance is lazily constructed when GetInstance() is called,
   // and destructed when the last scoped_refptr referring to it is destructed.
   static Provider* GetInstance();
 
   // Inject a mock Provider for testing. Only a weak pointer to the injected
   // object will be held by Provider, i.e. it does not itself contribute to the
@@ skipping 15 matching lines @@
  private:
   friend class base::RefCountedThreadSafe<Provider>;
   static Provider* instance_;
 
   DISALLOW_COPY_AND_ASSIGN(Provider);
 };
 
 }  // namespace device_orientation
 
 #endif  // CONTENT_BROWSER_DEVICE_ORIENTATION_PROVIDER_H_