content/renderer/media/peer_connection_handler_jsep.cc - Issue 10383151: Refactor MediaStreamImpl and PeerConnection glue implementation after WebKit changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/peer_connection_handler_jsep.cc

Issue 10383151: Refactor MediaStreamImpl and PeerConnection glue implementation after WebKit changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and added NON_EXPORTED_BASE to the base of MediaStreamExtradata. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/peer_connection_handler_jsep.h ('k') | content/renderer/media/peer_connection_handler_jsep_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/peer_connection_handler_jsep.cc

diff --git a/content/renderer/media/peer_connection_handler_jsep.cc b/content/renderer/media/peer_connection_handler_jsep.cc

index b524abe9487d91168b409fce22e107d9a39155a9..21ebe31ddf1bc5a6f3e60ee03302b4ca382a6c87 100644

--- a/content/renderer/media/peer_connection_handler_jsep.cc

+++ b/content/renderer/media/peer_connection_handler_jsep.cc

@@ -24,9 +24,8 @@

PeerConnectionHandlerJsep::PeerConnectionHandlerJsep(

WebKit::WebPeerConnection00HandlerClient* client,

- MediaStreamImpl* msi,

MediaStreamDependencyFactory* dependency_factory)

- : PeerConnectionHandlerBase(msi, dependency_factory),

+ : PeerConnectionHandlerBase(dependency_factory),

client_(client) {

}

@@ -183,11 +182,8 @@ void PeerConnectionHandlerJsep::removeStream(

}

void PeerConnectionHandlerJsep::stop() {

- // TODO(ronghuawu): There's an issue with signaling messages being sent during

- // close. We need to investigate further. Not calling Close() on native

- // PeerConnection is OK for now.

+ DVLOG(1) << "PeerConnectionHandlerJsep::stop";

native_peer_connection_ = NULL;

- media_stream_impl_->ClosePeerConnection(this);

}

void PeerConnectionHandlerJsep::OnError() {