Fix issue with stack layout assumption going wrong when a dart function has optional parameters and…

vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 528 matching lines @@
       __ Bind(&next_parameter);
     }
     delete[] opt_param;
     delete[] opt_param_position;
     // Check that EDI now points to the null terminator in the array descriptor.
     Label all_arguments_processed;
     __ cmpl(Address(EDI, 0), raw_null);
     __ j(EQUAL, &all_arguments_processed, Assembler::kNearJump);
 
     __ Bind(&wrong_num_arguments);
+    if (locals_space_size() != 0) {
+      // We need to unwind the space we reserved for locals/copied parms etc.

[regis, 2012/05/14 16:25:16]

locals/copied parms etc. -> locals and copied parameters. The NoSuchMethod stub
does not ...

[siva, 2012/05/15 21:51:15]

Done.

+      // for this method as the NoSuchMethodFunction stub does not expect to
+      // see that area on the stack.
+      __ addl(ESP, Immediate(locals_space_size()));
+    }
     if (function.IsClosureFunction()) {
       GenerateCallRuntime(AstNode::kNoId,
                           0,
                           kClosureArgumentMismatchRuntimeEntry);
     } else {
       // Invoke noSuchMethod function.
       const int kNumArgsChecked = 1;
       ICData& ic_data = ICData::ZoneHandle();
       ic_data = ICData::New(parsed_function().function(),
                             String::Handle(function.name()),
@@ skipping 2400 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32