Issue 10383143: Build Mac Chromoting pref-pane as universal binary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383143: Build Mac Chromoting pref-pane as universal binary (Closed)

Created:
8 years, 7 months ago by Lambros

Modified:
8 years, 7 months ago

Reviewers:
Sergey Ulanov, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build Mac Chromoting pref-pane as universal binary BUG=125116 TEST=manual

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -5 lines)			Patch
	M	remoting/remoting.gyp	View		1 chunk	+60 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lambros

This is more FYI, I'm not sure if we want to check this in? Note ...

8 years, 7 months ago (2012-05-11 22:00:59 UTC) #1

Jamie

As you mentioned the other day, the problem with this approach is that it means ...

8 years, 7 months ago (2012-05-11 22:04:52 UTC) #2

Sergey Ulanov

8 years, 7 months ago (2012-05-11 22:12:39 UTC) #3

http://codereview.chromium.org/10383143/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10383143/diff/1/remoting/remoting.gyp#newcode384
remoting/remoting.gyp:384: 'sources': [
Please add a comment here to explain why we need to rebuild all these files here
and can't depend on base.

Expand Messages | Collapse Messages