chrome/browser/webdata/autofill_profile_syncable_service.cc - Issue 10383127: Explode Autofill sync error messages for debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/autofill_profile_syncable_service.cc

Issue 10383127: Explode Autofill sync error messages for debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Return a SyncError, which includes a Location, rather than a bool+message Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/webdata/autofill_profile_syncable_service.cc

diff --git a/chrome/browser/webdata/autofill_profile_syncable_service.cc b/chrome/browser/webdata/autofill_profile_syncable_service.cc

index f65327a82a5f5a507ecd518199fc86686ec5551d..e715a137618d8eecb7ed2e85b3f1c19e97a997be 100644

--- a/chrome/browser/webdata/autofill_profile_syncable_service.cc

+++ b/chrome/browser/webdata/autofill_profile_syncable_service.cc

@@ -458,10 +458,11 @@ void AutofillProfileSyncableService::ActOnChange(

}

SyncError error = sync_processor_->ProcessSyncChanges(FROM_HERE, new_changes);

if (error.IsSet()) {

- DLOG(WARNING) << "[AUTOFILL SYNC]"

- << " Failed processing change:"

- << " Error:" << error.message()

- << " Guid:" << change.key();

+ // TODO(isherman): Investigating http://crbug.com/121592

+ VLOG(1) << "[AUTOFILL SYNC] "

+ << "Failed processing change:\n"

+ << " Error: " << error.message() << "\n"

+ << " Guid: " << change.key();

}