Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2311)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.h

Issue 10383104: Extract executeScript-like functionality into a single ExtensionScriptExecutor class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.h
diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
index 3fc5e14ef66cd57737255cc285abaf671cf706b4..9d49fcb1adbf680fe1c9fd74d159dcd6d51a34dc 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.h
@@ -56,6 +56,7 @@ class SyncedTabDelegate;
}
namespace extensions {
+class ScriptExecutor;
class WebNavigationTabObserver;
}
@@ -132,6 +133,10 @@ class TabContentsWrapper : public content::WebContentsObserver {
CoreTabHelper* core_tab_helper() { return core_tab_helper_.get(); }
+ extensions::ScriptExecutor* extensions_script_executor() {
+ return extensions_script_executor_.get();
+ }
+
ExtensionTabHelper* extension_tab_helper() {
return extension_tab_helper_.get();
}
@@ -228,6 +233,7 @@ class TabContentsWrapper : public content::WebContentsObserver {
scoped_ptr<BookmarkTabHelper> bookmark_tab_helper_;
scoped_ptr<ConstrainedWindowTabHelper> constrained_window_tab_helper_;
scoped_ptr<CoreTabHelper> core_tab_helper_;
+ scoped_ptr<extensions::ScriptExecutor> extensions_script_executor_;
Matt Perry 2012/05/11 22:47:38 nit: extension_script_executor_ for consistency
not at google - send to devlin 2012/05/14 02:27:16 Done.
scoped_ptr<ExtensionTabHelper> extension_tab_helper_;
scoped_ptr<FaviconTabHelper> favicon_tab_helper_;
scoped_ptr<FindTabHelper> find_tab_helper_;

Powered by Google App Engine
This is Rietveld 408576698