Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: chrome/browser/extensions/execute_code_in_tab_function.h

Issue 10383104: Extract executeScript-like functionality into a single ExtensionScriptExecutor class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/execute_code_in_tab_function.h
diff --git a/chrome/browser/extensions/execute_code_in_tab_function.h b/chrome/browser/extensions/execute_code_in_tab_function.h
index 81cee16c7a4241fc4c8ad4d4501f8ca5c3b23c57..21ef63b6ebd6261e2141ffe103c31c6933f06fe1 100644
--- a/chrome/browser/extensions/execute_code_in_tab_function.h
+++ b/chrome/browser/extensions/execute_code_in_tab_function.h
@@ -11,11 +11,9 @@
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/common/extensions/extension_resource.h"
#include "chrome/common/extensions/user_script.h"
-#include "content/public/browser/web_contents_observer.h"
// Implement API call tabs.executeScript and tabs.insertCSS.
-class ExecuteCodeInTabFunction : public AsyncExtensionFunction,
- public content::WebContentsObserver {
+class ExecuteCodeInTabFunction : public AsyncExtensionFunction {
public:
ExecuteCodeInTabFunction();
@@ -26,12 +24,8 @@ class ExecuteCodeInTabFunction : public AsyncExtensionFunction,
virtual bool RunImpl() OVERRIDE;
private:
- // content::WebContentsObserver overrides.
- virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
-
// Message handler.
- void OnExecuteCodeFinished(int request_id, bool success,
- const std::string& error);
+ void OnExecuteCodeFinished(bool success, const std::string& error);
// Called when contents from the file whose path is specified in JSON
// arguments has been loaded.

Powered by Google App Engine
This is Rietveld 408576698