Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: chrome/browser/extensions/script_executor_impl.cc

Issue 10383104: Extract executeScript-like functionality into a single ExtensionScriptExecutor class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/script_executor_impl.cc
diff --git a/chrome/browser/extensions/script_executor_impl.cc b/chrome/browser/extensions/script_executor_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7b3d73745f3fb328881bdaafacdb835b60e71326
--- /dev/null
+++ b/chrome/browser/extensions/script_executor_impl.cc
@@ -0,0 +1,107 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/script_executor_impl.h"
+
+#include "base/callback.h"
+#include "base/logging.h"
+#include "base/pickle.h"
+#include "chrome/common/extensions/extension_messages.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "ipc/ipc_message.h"
+#include "ipc/ipc_message_macros.h"
+
+namespace extensions {
+
+namespace {
+
+const char* kRendererDestroyed = "The tab was closed.";
+
+// A handler for a single injection request. On creation this will send the
+// injection request to the renderer, and it will be destroyed after either the
+// corresponding response comes from the renderer, or the renderer is destroyed.
+class Handler : public content::WebContentsObserver {
+ public:
+ Handler(content::WebContents* web_contents,
+ const ExtensionMsg_ExecuteCode_Params params,
+ const ScriptExecutor::ExecuteScriptCallback& callback)
+ : content::WebContentsObserver(web_contents),
+ request_id_(params.request_id),
+ callback_(callback) {
+ content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
+ rvh->Send(new ExtensionMsg_ExecuteCode(rvh->GetRoutingID(), params));
+ }
+
+ virtual ~Handler() {}
+
+ virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE {
+ // Unpack by hand to check the request_id, since there may be multiple
+ // requests in flight but only one is for this.
+ if (message.type() != ExtensionHostMsg_ExecuteCodeFinished::ID)
+ return false;
+
+ int message_request_id;
+ PickleIterator iter(message);
+ CHECK(message.ReadInt(&iter, &message_request_id));
+
+ if (message_request_id != request_id_)
+ return false;
+
+ IPC_BEGIN_MESSAGE_MAP(Handler, message)
+ IPC_MESSAGE_HANDLER(ExtensionHostMsg_ExecuteCodeFinished,
+ OnExecuteCodeFinished)
+ IPC_END_MESSAGE_MAP()
+ return true;
+ }
+
+ virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE {
+ callback_.Run(false, kRendererDestroyed);
+ delete this;
+ }
+
+ private:
+ void OnExecuteCodeFinished(int request_id,
+ bool success,
+ const std::string& error) {
+ callback_.Run(success, error);
+ delete this;
+ }
+
+ int request_id_;
+ ScriptExecutor::ExecuteScriptCallback callback_;
+};
+
+} // namespace
+
+ScriptExecutorImpl::ScriptExecutorImpl(
+ content::WebContents* web_contents)
+ : next_request_id_(0),
+ web_contents_(web_contents) {}
+
+ScriptExecutorImpl::~ScriptExecutorImpl() {}
+
+void ScriptExecutorImpl::ExecuteScript(
+ const std::string& extension_id,
+ ScriptExecutor::ScriptType script_type,
+ const std::string& code,
+ ScriptExecutor::FrameScope frame_scope,
+ UserScript::RunLocation run_at,
+ ScriptExecutor::WorldType world_type,
+ const ExecuteScriptCallback& callback) {
+ ExtensionMsg_ExecuteCode_Params params;
+ params.request_id = next_request_id_++;
+ params.extension_id = extension_id;
+ params.is_javascript = (script_type == JAVASCRIPT);
+ params.code = code;
+ params.all_frames = (frame_scope == ALL_FRAMES);
+ params.run_at = (int) run_at;
+ params.in_main_world = (world_type == MAIN_WORLD);
+
+ // Handler handles IPCs and deletes itself on completion.
+ new Handler(web_contents_, params, callback);
+}
+
+} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/script_executor_impl.h ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698