Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 10383104: Extract executeScript-like functionality into a single ExtensionScriptExecutor class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h
index 085b7437733c31195c734e4eb9918c8069110abf..7d9d81d4043f329ff1a97c5b592b37fff99ae2eb 100644
--- a/chrome/browser/extensions/extension_tabs_module.h
+++ b/chrome/browser/extensions/extension_tabs_module.h
@@ -13,7 +13,6 @@
#include "chrome/browser/extensions/extension_function.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/web_contents_observer.h"
#include "googleurl/src/gurl.h"
class BackingStore;
@@ -113,8 +112,7 @@ class HighlightTabsFunction : public SyncExtensionFunction {
virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("tabs.highlight")
};
-class UpdateTabFunction : public AsyncExtensionFunction,
- public content::WebContentsObserver {
+class UpdateTabFunction : public AsyncExtensionFunction {
public:
UpdateTabFunction();
@@ -124,15 +122,11 @@ class UpdateTabFunction : public AsyncExtensionFunction,
bool* is_async);
virtual void PopulateResult();
- content::WebContents* web_contents_;
+ TabContentsWrapper* tab_contents_;
private:
virtual bool RunImpl() OVERRIDE;
- virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
- virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
- void OnExecuteCodeFinished(int request_id,
- bool success,
- const std::string& error);
+ void OnExecuteCodeFinished(bool success, const std::string& error);
DECLARE_EXTENSION_FUNCTION_NAME("tabs.update")
};
« no previous file with comments | « chrome/browser/extensions/execute_code_in_tab_function.cc ('k') | chrome/browser/extensions/extension_tabs_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698