Add support to SystemTray for a second notification bubble.

Add support to SystemTray for a second bubble for notifications.

This does not include any code that adds notifications yet, that will follow.

BUG=124269
TEST=SystemTrayTest passes, system tray behavior is unchanged.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136090

[sadrul, 2012-05-08 19:40:17]

Nice. LGTM with the nits

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (right):

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:588: views::Widget* widget =
anchor_->GetWidget();
I think instead of keeping anchor_ around, you can use
bubble_view_->anchor_widget() here

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:702: SystemTray* host_;
DISALLOW_COPY_AND_ASSIGN

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:950: void SystemTray::ShowNotifications() {
Since this can hide the notifications in some cases, I would call this
UpdateNotificationBubble or something like that, instead of Show...

[stevenjb, 2012-05-08 22:49:20]

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (right):

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:588: views::Widget* widget =
anchor_->GetWidget();
On 2012/05/08 19:40:17, sadrul wrote:
> I think instead of keeping anchor_ around, you can use
> bubble_view_->anchor_widget() here
Good call. Done.

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:702: SystemTray* host_;
On 2012/05/08 19:40:17, sadrul wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

http://codereview.chromium.org/10383045/diff/7001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:950: void SystemTray::ShowNotifications() {
On 2012/05/08 19:40:17, sadrul wrote:
> Since this can hide the notifications in some cases, I would call this
> UpdateNotificationBubble or something like that, instead of Show...

Done.

[commit-bot: I haz the power, 2012-05-09 16:21:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10383045/13002

[commit-bot: I haz the power, 2012-05-09 19:15:56]

Change committed as 136090