Add scale factor and 2x resources from webkit and plumb through to ContentClient.

Add scale factor and 2x resources from webkit and plumb through to ContentClient.

BUG=124158
TEST=Run debug chrome with --default-device-scale-factor=2 and view a textarea with scrollbars. The previously blank assets are now there and chrome no longer crashes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136610

[flackr, 2012-05-04 15:20:38]

Hi tony,

Can you take a look at this change. Chrome crashes in 2x mode because we ask for
resources like textAreaResizeCorner@2x. In chrome both the 1x and 2x resource
are identified by the same resource ID in ResourceBundle so we need to parse out
the scale factor and pass it to ResourceBundle (after support has been added to
fetch a resource for a particular scale factor from ResourceBundle).

Thanks,
Rob

[tony, 2012-05-04 17:37:54]

from IM discussion:
flackr said he would look to see where the @2x comes from.  Maybe we can avoid
unnecessary string operations and pass in the name & scaleFactor into
WebKitPlatformSupportImpl::loadResource.

[flackr, 2012-05-04 19:58:25]

On 2012/05/04 17:37:54, tony wrote:
> from IM discussion:
> flackr said he would look to see where the @2x comes from.  Maybe we can avoid
> unnecessary string operations and pass in the name & scaleFactor into
> WebKitPlatformSupportImpl::loadResource.

I looked into this, https://bugs.webkit.org/show_bug.cgi?id=67819 adds several
assets to WebKit in the format filename@2x.png and has several hard-coded blocks
like so:
if (deviceScaleFactor >= 2) {
  loadPlatformResource("filename@2x");
  ...
} else {
  loadPlatformResource("filename");
  ...
}

This resource name is then passed on to
WebCore::PlatformSupport::loadPlatformImageResource. Given that these are
hard-coded one off cases maybe I should just add strings to the chromium
webkitplatformsupport_impl list for the "@2x" resources and include the scale
factors in this list? Your thoughts? Thanks.

[tony, 2012-05-04 20:34:38]

On 2012/05/04 19:58:25, flackr wrote:
> Given that these are
> hard-coded one off cases maybe I should just add strings to the chromium
> webkitplatformsupport_impl list for the "@2x" resources and include the scale
> factors in this list? Your thoughts? Thanks.

Yes, I like this idea.

Someday, we should convert the linear search into a trie.  Maybe add a TODO for
that.

[flackr, 2012-05-05 03:01:44]

On 2012/05/04 20:34:38, tony wrote:
> On 2012/05/04 19:58:25, flackr wrote:
> > Given that these are
> > hard-coded one off cases maybe I should just add strings to the chromium
> > webkitplatformsupport_impl list for the "@2x" resources and include the
scale
> > factors in this list? Your thoughts? Thanks.
> 
> Yes, I like this idea.
> 
> Someday, we should convert the linear search into a trie.  Maybe add a TODO
for
> that.

Done.

[tony, 2012-05-07 17:02:34]

LGTM

https://chromiumcodereview.appspot.com/10383006/diff/6012/webkit/glue/webkitp...
File webkit/glue/webkitplatformsupport_impl.cc (right):

https://chromiumcodereview.appspot.com/10383006/diff/6012/webkit/glue/webkitp...
webkit/glue/webkitplatformsupport_impl.cc:389: { "missingImage@2x",
IDR_BROKENIMAGE, 2.0 },
Nit: I would have just made a second list of 2x resources and search both lists,
but this is OK too.

[flackr, 2012-05-07 17:44:48]

+ben for content/*

Take a look when you get a chance, thanks!

[flackr, 2012-05-09 13:58:20]

ben, ping, just in case this got buried in email :-).

[Ben Goodger (Google), 2012-05-09 17:42:26]

On 2012/05/09 13:58:20, flackr wrote:
> ben, ping, just in case this got buried in email :-).

LGTM

[commit-bot: I haz the power, 2012-05-09 17:58:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/10383006/11001

[commit-bot: I haz the power, 2012-05-09 18:12:21]

Try job failure for 10383006-11001 (retry) on android for steps "Compile,
build".
It's a second try, previously, steps "Compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-05-09 20:04:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/10383006/11001

[commit-bot: I haz the power, 2012-05-09 20:21:43]

Try job failure for 10383006-11001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-05-09 20:36:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/10383006/11004

[commit-bot: I haz the power, 2012-05-09 21:02:41]

Try job failure for 10383006-11004 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[tony, 2012-05-11 18:06:53]

I committed this manually (it was blocking part of the android upstreaming):
https://src.chromium.org/viewvc/chrome?view=rev&revision=136610