Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.cc

Issue 10382216: Remove browser-actions-for-all flag and replace funcionality with action-box. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_actions_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
index 771c9f96b17cef6c3ac15a5b2c5f98f5e44ad6c0..ea4b2237d2a1db2cf6b3285fe94417c5867de6d2 100644
--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.cc
@@ -158,7 +158,7 @@ bool ExtensionActionFunction::ParseCSSColorString(
}
bool ExtensionActionFunction::SetVisible(bool visible) {
- // If --browser-actions-for-all is enabled there will be a browser_action
+ // If --extension-action-box is enabled there will be a browser_action
Aaron Boodman 2012/05/17 04:34:29 --enable-action-box
not at google - send to devlin 2012/05/17 04:38:17 Done.
// here instead of a page action. Until we decide what to do with that, just
// ignore.
if (!GetExtension()->page_action())
@@ -189,7 +189,7 @@ bool ExtensionActionSetIconFunction::RunExtensionAction() {
IPC::ReadParam(&bitmap_pickle, &iter, &bitmap));
extension_action_->SetIcon(tab_id_, bitmap);
} else if (details_->GetInteger("iconIndex", &icon_index)) {
- // If --browser-actions-for-all is enabled there might legitimately be an
+ // If --extension-action-box is enabled there might legitimately be an
// iconIndex set. Until we decide what to do with that, ignore.
if (!GetExtension()->page_action())
return true;
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698