Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: remoting/proto/video.proto

Issue 10382184: [Chromoting] Initial plumbing for cursor shape. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment for CaptureCursor Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/proto/video.proto
diff --git a/remoting/proto/video.proto b/remoting/proto/video.proto
index 14415af4585e55ceb3f54a346d99c525de748a5d..a4ffe871de57aabd118bd7617f7db3bc42de3ce1 100644
--- a/remoting/proto/video.proto
+++ b/remoting/proto/video.proto
@@ -35,6 +35,18 @@ message VideoPacketFormat {
optional int32 screen_height = 7;
}
+message CursorShapeInfo {
Sergey Ulanov 2012/05/15 23:51:34 Why is this in video.proto? wouldn't it be better
Wez 2012/05/16 00:20:04 We discussed this and agreed the video channel was
Sergey Ulanov 2012/05/16 20:39:12 As we discussed yesterday: It may be better to use
garykac 2012/05/22 00:42:03 Done.
+ // Width, height (in screen pixels) of the cursor (and mask).
+ optional int32 width = 1;
+ optional int32 height = 2;
+
+ // X,Y coordinates (in screen pixels) of the cursor hotspot.
+ optional int32 hotspot_x = 3;
+ optional int32 hotspot_y = 4;
+
+ // Cursor pixmap data is stored in VideoPacket |data| field.
+}
+
// TODO(hclam): Remove this message once we can obtain dirty rects from libvpx.
message Rect {
optional int32 x = 1;
@@ -61,10 +73,13 @@ message VideoPacket {
// a LAST_PACKET.
// * All packets in one logical update must be processed in order, and
// packets may not be skipped.
+ // CURSOR_SHAPE specifies a standalone cursor shape packet. These packets
+ // are not combined with any other video packet.
enum Flags {
FIRST_PACKET = 1;
LAST_PACKET = 2;
LAST_PARTITION = 4;
+ CURSOR_SHAPE = 8;
Sergey Ulanov 2012/05/15 23:51:34 Do we really need a flag for this? We can just use
garykac 2012/05/22 00:42:03 Done.
}
optional int32 flags = 1 [default = 0];
@@ -94,4 +109,7 @@ message VideoPacket {
// The most recent sequence number received from the client on the event
// channel.
optional int64 client_sequence_number = 9;
+
+ // Description of the current cursor shape.
+ optional CursorShapeInfo cursor_shape = 10;
}

Powered by Google App Engine
This is Rietveld 408576698