[Chromoting] Initial plumbing for cursor shape.

remoting/client/plugin/pepper_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/pepper_view.h"
 
 #include <functional>
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/synchronization/waitable_event.h"
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/graphics_2d.h"
 #include "ppapi/cpp/image_data.h"
+#include "ppapi/cpp/mouse_cursor.h"
 #include "ppapi/cpp/point.h"
 #include "ppapi/cpp/rect.h"
 #include "ppapi/cpp/size.h"
 #include "remoting/base/util.h"
 #include "remoting/client/chromoting_stats.h"
 #include "remoting/client/client_context.h"
 #include "remoting/client/frame_producer.h"
 #include "remoting/client/plugin/chromoting_instance.h"
 #include "remoting/client/plugin/pepper_util.h"
 
@@ skipping 117 matching lines @@
           ChromotingInstance::STATE_FAILED,
           ConvertConnectionError(error));
       break;
   }
 }
 
 protocol::ClipboardStub* PepperView::GetClipboardStub() {
   return instance_;
 }
 
+void PepperView::SetCursorShape(const protocol::CursorShapeInfo& cursor_shape) {
+  if (!cursor_shape.has_data())
+    return;
+
+  int width = cursor_shape.width();

[Wez, 2012/05/23 00:01:57]

This and the other fields you use below are option, so you should early-exit if
they're not present as you do for data().

[garykac, 2012/05/26 01:58:01]

Done.

+  int height = cursor_shape.height();
+  int hotspot_x = cursor_shape.hotspot_x();
+  int hotspot_y = cursor_shape.hotspot_y();
+
+  pp::ImageData* cursor_image;
+  cursor_image = new pp::ImageData(instance_,
+                                   PP_IMAGEDATAFORMAT_BGRA_PREMUL,
+                                   pp::Size(width, height),
+                                   false);

[Wez, 2012/05/23 00:01:57]

You're leaking the C++ wrapper for the ImageData resource; it should be created
on the stack.

[garykac, 2012/05/26 01:58:01]

Done.

+
+  int total_bytes = width * height * 4;
+  memcpy(cursor_image->data(), cursor_shape.data().data(), total_bytes);

[Wez, 2012/05/23 00:01:57]

Are we guaranteed that the stride of the ImageData matches the width?

[garykac, 2012/05/26 01:58:01]

Done.

+
+  // TODO(garykac) Use pp::ImageData::GetNativeImageDataFormat() and
+  // constrain to 32x32 pixels.

[Wez, 2012/05/23 00:01:57]

nit: Clarify that this is because the SetCursor() API places those requirements.

The API seems to complete synchronously; does it block until the operation is
complete?

[garykac, 2012/05/26 01:58:01]

Done.

+  pp::MouseCursor::SetCursor(instance_, PP_MOUSECURSOR_TYPE_CUSTOM,
+                             *cursor_image,
+                             pp::Point(hotspot_x, hotspot_y));
+}
+
 void PepperView::SetView(const SkISize& view_size, const SkIRect& clip_area) {
   bool view_changed = false;
 
   if (view_size_ != view_size) {
     view_changed = true;
     view_size_ = view_size;
 
     pp::Size pp_size = pp::Size(view_size_.width(), view_size_.height());
     graphics2d_ = pp::Graphics2D(instance_, pp_size, true);
     bool result = instance_->BindGraphics(graphics2d_);
@@ skipping 177 matching lines @@
 
   // If there is a buffer queued for rendering then render it now.
   if (merge_buffer_ != NULL) {
     buffer = merge_buffer_;
     merge_buffer_ = NULL;
     FlushBuffer(merge_clip_area_, buffer, merge_region_);
   }
 }
 
 }  // namespace remoting