[Chromoting] Initial plumbing for cursor shape.

remoting/client/chromoting_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_client.h"
 
 #include "base/bind.h"
 #include "remoting/client/chromoting_view.h"
 #include "remoting/client/client_context.h"
 #include "remoting/client/rectangle_update_decoder.h"
@@ skipping 46 matching lines @@
     authenticator.reset(new protocol::V1ClientAuthenticator(
         config_.local_jid, config_.shared_secret));
   } else {
     authenticator = protocol::NegotiatingAuthenticator::CreateForClient(
         config_.authentication_tag,
         config_.shared_secret, config_.authentication_methods);
   }
 
   connection_->Connect(xmpp_proxy, config_.local_jid, config_.host_jid,
                        config_.host_public_key, transport_factory.Pass(),
-                       authenticator.Pass(), this, this, this, this);
+                       authenticator.Pass(), this, this, this, this, this);
 
   if (!view_->Initialize()) {
     ClientDone();
   }
 }
 
 void ChromotingClient::Stop(const base::Closure& shutdown_task) {
   if (!message_loop()->BelongsToCurrentThread()) {
     message_loop()->PostTask(
         FROM_HERE, base::Bind(&ChromotingClient::Stop,
@@ skipping 27 matching lines @@
 
 ChromotingStats* ChromotingClient::GetStats() {
   return &stats_;
 }
 
 void ChromotingClient::InjectClipboardEvent(
     const protocol::ClipboardEvent& event) {
   view_->GetClipboardStub()->InjectClipboardEvent(event);
 }
 
+void ChromotingClient::SetCursorShape(
+    const protocol::CursorShapeInfo& cursor_shape) {

[Wez, 2012/05/23 00:01:57]

Do we actually need ChromotingClient to implement CursorShapeStub?  Could we
instead pass the |view_| directly to Connect()?  (And similarly for
ClipboardStub, actually)

[garykac, 2012/05/26 01:58:01]

ChromotingClient is currently where we handle all of the messages received from
the host. We (+sergey, simon) should setup a protocol discussion meeting and
discuss how we'd like to change it.

+  if (cursor_shape.has_data()) {

[Wez, 2012/05/23 00:01:57]

The SetCursorShape() API doesn't specify any requirement that has_data() be
true, and the PepperView implementation checks it itself, so there's no need to
check here.

[garykac, 2012/05/26 01:58:01]

Done.

+    view_->SetCursorShape(cursor_shape);
+  }
+}
+
 void ChromotingClient::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,
                                           const base::Closure& done) {
   DCHECK(message_loop()->BelongsToCurrentThread());
 
   // If the video packet is empty then drop it. Empty packets are used to
   // maintain activity on the network.
   if (!packet->has_data() || packet->data().size() == 0) {
     done.Run();
     return;
   }
@@ skipping 94 matching lines @@
     thread_proxy_.PostTask(FROM_HERE, base::Bind(
         &ChromotingClient::Initialize, base::Unretained(this)));
     return;
   }
 
   // Initialize the decoder.
   rectangle_decoder_->Initialize(connection_->config());
 }
 
 }  // namespace remoting