Fix bug in ninja generator when there's no default action.

test/rules/src/subdir2/no_action.gyp

+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Test that the case where an action is only specified under a conditional is evaulated appropriately.

[Nico, 2012/05/15 17:21:57]

80-col wrap comments

typo evaulated

[Yaron, 2012/05/15 17:36:13]

Done.

+{
+  'targets': [
+    {
+      'target_name': 'extension_does_not_match_sources_and_no_action',
+      'type': 'none',
+      'msvs_cygwin_shell': 0,
+      'sources': [
+        'file1.in',
+        'file2.in',
+      ],
+      'rules': [
+        {
+          'rule_name': 'assemble',
+          'extension': 'asm',
+          'outputs': [
+            '<(RULE_INPUT_ROOT).fail',
+          ],
+          'conditions': [
+            # Always fails.
+            [ '"true"=="false"', {
+              'action': [
+                'python', '../copy-file.py', '<(RULE_INPUT_PATH)', '<@(_outputs)',
+              ],
+              'process_outputs_as_sources': 1,
+              'message': 'test_rule',
+            }],
+          ],
+        },

[Nico, 2012/05/15 17:21:57]

Reading the make generator code, it looks like it would throw for rules that
have no action but non-empty rule_sources. Ninja will ignore those silently with
your patch. Do you think there should be a test for that case? What should the
expected behavior be? Maybe ninja should only skip rules without action if not
rule.get('rule_sources', [])?

[Yaron, 2012/05/15 17:36:13]

Done. Is there an "expect fails to gyp" option? I don't see one and catching
KeyError seems too broad.

[Nico, 2012/05/15 17:43:22]

test.run_gyp('my-gyp-file.gyp', chdir='src', status=1, stderr=None)

See e.g. test/same-name/gyptest-fail.py

+      ],
+    },
+  ],
+}