Refactor the various ways to control what users can do to extensions.

chrome/browser/extensions/test_extension_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/test_extension_system.h"
 
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/extension_devtools_manager.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_info_map.h"
@@ skipping 46 matching lines @@
   extension_prefs_->Init(extensions_disabled);
   extension_service_.reset(new ExtensionService(profile_,
                                                 command_line,
                                                 install_directory,
                                                 extension_prefs_.get(),
                                                 autoupdate_enabled,
                                                 true));
   return extension_service_.get();
 }
 
+extensions::ManagementPolicy* TestExtensionSystem::CreateManagementPolicy() {
+  management_policy_.reset(new extensions::ManagementPolicy());
+
+  DCHECK(extension_prefs_.get());
+  management_policy_->RegisterProvider(extension_prefs_.get());
+  DCHECK(extension_service_.get());
+  management_policy_->RegisterProvider(extension_service_.get());
+
+  return management_policy_.get();
+}
+
 ExtensionService* TestExtensionSystem::extension_service() {
   return extension_service_.get();
 }
 
+extensions::ManagementPolicy* TestExtensionSystem::management_policy() {

[Aaron Boodman, 2012/05/22 15:56:11]

Why bother overriding this? ManagementPolicy is fine to use in tests as it is...
if callers want they can ClearProviders() on it and add their own. Seems a
little simpler.

[Pam (message me for reviews), 2012/05/23 15:00:58]

TestExtensionSystem is a subclass of ExtensionSystem, not of
ExtensionSystemImpl, so we need to implement the abstract method here. And
management_policy_ is private to ExtensionSystemImpl::Shared, normally exposed
only via the ExtensionSystemImpl, so we need a local one for testing.

+  return management_policy_.get();
+}
+
 void TestExtensionSystem::SetExtensionService(ExtensionService* service) {
   extension_service_.reset(service);
 }
 
 UserScriptMaster* TestExtensionSystem::user_script_master() {
   return NULL;
 }
 
 ExtensionDevToolsManager* TestExtensionSystem::devtools_manager() {
   return NULL;
@@ skipping 26 matching lines @@
 
 extensions::RulesRegistryService*
 TestExtensionSystem::rules_registry_service() {
   return NULL;
 }
 
 // static
 ProfileKeyedService* TestExtensionSystem::Build(Profile* profile) {
   return new TestExtensionSystem(profile);
 }