Refactor the various ways to control what users can do to extensions.

chrome/browser/extensions/extension_management_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
+#include "chrome/browser/extensions/test_management_policy.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 
+using extensions::Extension;
+
 namespace {
 
 // Find a browser other than |browser|.
 Browser* FindOtherBrowser(Browser* browser) {
   Browser* found = NULL;
   for (BrowserList::const_iterator it = BrowserList::begin();
        it != BrowserList::end(); ++it) {
     if (*it == browser)
       continue;
     found = *it;
@@ skipping 32 matching lines @@
   void LoadAndWaitForLaunch(const std::string& app_path,
                             std::string* out_app_id) {
     ExtensionTestMessageListener launched_app("launched app", false);
     ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII(app_path)));
 
     if (out_app_id)
       *out_app_id = last_loaded_extension_id_;
 
     ASSERT_TRUE(launched_app.WaitUntilSatisfied());
   }
+
+  // Returns the extension ID of the first extension found with the given |name|
+  // (from its manifest), or an empty string if no match was found. Includes
+  // both enabled and disabled extensions.
+  std::string GetExtensionIdByName(const ExtensionService* service,

[Aaron Boodman, 2012/05/22 15:56:11]

LoadExtension() returns Extension*. You can just store the extensions as you
load them as member data, then you don't need this.

+                                   const std::string& name) {
+    for (ExtensionSet::const_iterator iter = service->extensions()->begin();
+         iter != service->extensions()->end(); ++iter) {
+      const Extension* extension = (*iter);
+      if (extension->name() == name)
+        return extension->id();
+    }
+    for (ExtensionSet::const_iterator iter =
+          service->disabled_extensions()->begin();
+        iter != service->disabled_extensions()->end();
+        ++iter) {
+      const Extension* extension = (*iter);
+      if (extension->name() == name)
+        return extension->id();
+    }
+    return "";
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Basics) {
   InstallExtensions();
   ASSERT_TRUE(RunExtensionSubtest("management/test", "basics.html"));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Uninstall) {
   InstallExtensions();
   ASSERT_TRUE(RunExtensionSubtest("management/test", "uninstall.html"));
 }
 
+// Tests actions on extensions when no management policy is in place.
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, ManagementPolicyAllowed) {
+  InstallExtensions();
+  ExtensionService* service = browser()->profile()->GetExtensionService();
+  std::string id = GetExtensionIdByName(service, "enabled_extension");
+  EXPECT_NE("", id);
+
+  // Ensure that all actions are allowed.
+  ExtensionSystem::Get(browser()->profile())->management_policy()
+      ->UnregisterAllProviders();
+
+  ASSERT_TRUE(RunExtensionSubtest("management/management_policy",
+                                  "allowed.html"));
+  // The last thing the test does is uninstall the "enabled_extension".
+  id = GetExtensionIdByName(service, "enabled_extension");
+  EXPECT_EQ("", id);
+}
+
+// Tests actions on extensions when management policy prohibits those actions.
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, ManagementPolicyProhibited) {
+  InstallExtensions();
+  ExtensionService* service = browser()->profile()->GetExtensionService();
+  std::string id = GetExtensionIdByName(service, "enabled_extension");
+  EXPECT_NE("", id);
+
+  // Prohibit status changes.
+  extensions::ManagementPolicy* policy =
+      ExtensionSystem::Get(browser()->profile())->management_policy();
+  policy->UnregisterAllProviders();
+  extensions::TestManagementPolicyProvider provider(
+    extensions::TestManagementPolicyProvider::PROHIBIT_MODIFY_STATUS);
+  policy->RegisterProvider(&provider);
+  ASSERT_TRUE(RunExtensionSubtest("management/management_policy",
+                                  "prohibited.html"));
+}
+
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchPanelApp) {
   ExtensionService* service = browser()->profile()->GetExtensionService();
 
   // Load an extension that calls launchApp() on any app that gets
   // installed.
   ExtensionTestMessageListener launcher_loaded("launcher loaded", false);
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("management/launch_on_install")));
   ASSERT_TRUE(launcher_loaded.WaitUntilSatisfied());
 
@@ skipping 89 matching lines @@
   ASSERT_EQ(2, browser()->tab_count());
 #else
   // Find the app's browser.  Opening in a new window will create
   // a new browser.
   ASSERT_EQ(2u, browser::GetBrowserCount(browser()->profile()));
   Browser* app_browser = FindOtherBrowser(browser());
   ASSERT_TRUE(app_browser->is_app());
   ASSERT_FALSE(app_browser->is_type_panel());
 #endif
 }