Refactor the various ways to control what users can do to extensions.

chrome/browser/extensions/extension_context_menu_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/extensions/extension_context_menu_model.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
+#include "chrome/browser/extensions/test_management_policy.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/common/context_menu_params.h"
 #include "net/base/mock_host_resolver.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebContextMenuData.h"
 #include "ui/base/models/menu_model.h"
 
@@ skipping 481 matching lines @@
       page_url, GURL(), frame_url, std::string("Page item")));
   ASSERT_TRUE(MenuHasItemWithLabel(
       page_url, GURL(), frame_url, std::string("Frame item")));
 }
 
 // Tests enabling and disabling a context menu item.
 IN_PROC_BROWSER_TEST_F(ExtensionContextMenuBrowserTest, Enabled) {
   TestEnabledContextMenu(true);
   TestEnabledContextMenu(false);
 }
+
+// Tests that applicable menu items are disabled when a ManagementPolicy
+// prohibits them.
+IN_PROC_BROWSER_TEST_F(ExtensionContextMenuBrowserTest, PolicyDisablesItems) {
+  ASSERT_TRUE(LoadContextMenuExtension("simple"));
+  ExtensionService* service = browser()->profile()->GetExtensionService();
+  ASSERT_TRUE(service != NULL);
+  ASSERT_FALSE(service->extensions()->is_empty());
+  // We need an extension to pass to the menu constructor, but we don't care

[Aaron Boodman, 2012/05/22 15:56:11]

Nit: add a blank line here.

+  // which one.
+  ExtensionSet::const_iterator i = service->extensions()->begin();
+  const extensions::Extension* extension = *i;
+  ASSERT_TRUE(extension != NULL);
+
+  scoped_refptr<ExtensionContextMenuModel> menu(
+      new ExtensionContextMenuModel(extension, browser()));
+
+  ExtensionSystem::Get(
+      browser()->profile())->management_policy()->UnregisterAllProviders();
+
+  // Actions should be enabled.
+  ASSERT_TRUE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::DISABLE));
+  ASSERT_TRUE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL));
+
+  extensions::TestManagementPolicyProvider policy_provider(
+    extensions::TestManagementPolicyProvider::PROHIBIT_MODIFY_STATUS);
+  ExtensionSystem::Get(
+      browser()->profile())->management_policy()->RegisterProvider(
+      &policy_provider);
+
+  // Now the actions are disabled.
+  ASSERT_FALSE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::DISABLE));
+  ASSERT_FALSE(menu->IsCommandIdEnabled(ExtensionContextMenuModel::UNINSTALL));

[Aaron Boodman, 2012/05/22 15:56:11]

Yay, this came out clean.

+}