Refactor the various ways to control what users can do to extensions.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   'use strict';
 
   /**
    * A lookup helper function to find the first node that has an id (starting
    * at |node| and going up the parent chain).
@@ skipping 30 matching lines @@
 
       this.showExtensionNodes_();
     },
 
     /**
      * Creates all extension items from scratch.
      * @private
      */
      showExtensionNodes_: function() {
        // Iterate over the extension data and add each item to the list.
-       var list = this;
-       this.data_.extensions.forEach(this.createNode_.bind(this));
+       this.data_.extensions.forEach(this.createNode_, this);
 
        if (this.data_.extensions.length == 0)
          this.classList.add('empty-extension-list');
        else
          this.classList.remove('empty-extension-list');
      },
 
      /**
       * Synthesizes and initializes an HTML element for the extension metadata
       * given in |extension|.
       * @param {Object} extension A dictionary of extension metadata.
       * @private
       */
      createNode_: function(extension) {
       var template = $('template-collection').querySelector(
           '.extension-list-item-wrapper');
       var node = template.cloneNode(true);
       node.id = extension.id;
 
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
 
-      if (!extension.mayDisable)
+      if (!extension.mayModifySettings)
         node.classList.add('may-not-disable');
 
       var item = node.querySelector('.extension-list-item');
       item.style.backgroundImage = 'url(' + extension.icon + ')';
 
       var title = node.querySelector('.extension-title');
       title.textContent = extension.name;
 
       var version = node.querySelector('.extension-version');
       version.textContent = extension.version;
@@ skipping 63 matching lines @@
 
       // The 'Reload' checkbox.
       if (extension.allow_reload) {
         var reload = node.querySelector('.reload-link');
         reload.addEventListener('click', function(e) {
           chrome.send('extensionSettingsReload', [extension.id]);
         });
         reload.hidden = false;
       }
 
+      // Disable optional controls if they cannot be used.
+      node.querySelector('.optional-controls').hidden =
+          !extension.mayModifySettings;

[Evan Stade, 2012/05/30 21:20:01]

.may-not-disable .optional-controls {
  display: none;
}

also I wonder why you chose to hide them over greying them out, like for a
disabled extension?

+
       if (!extension.terminated) {
         // The 'Enabled' checkbox.
         var enable = node.querySelector('.enable-checkbox');
         enable.hidden = false;
-        enable.querySelector('input').disabled = !extension.mayDisable;
+        enable.querySelector('input').disabled = !extension.mayModifySettings;
 
-        if (extension.mayDisable) {
+        if (extension.mayModifySettings) {
           enable.addEventListener('click', function(e) {
             chrome.send('extensionSettingsEnable',
                         [extension.id, e.target.checked ? 'true' : 'false']);
           });
         }
 
         enable.querySelector('input').checked = extension.enabled;
       } else {
         var terminated_reload = node.querySelector('.terminated-reload-link');
         terminated_reload.hidden = false;
@@ skipping 19 matching lines @@
 
       // Then the path, if provided by unpacked extension.
       if (extension.isUnpacked) {
         var loadPath = node.querySelector('.load-path');
         loadPath.hidden = false;
         loadPath.querySelector('span:nth-of-type(2)').textContent =
             ' ' + extension.path;
       }
 
       // Then the 'managed, cannot uninstall/disable' message.
-      if (!extension.mayDisable)
+      if (!extension.mayModifySettings)
         node.querySelector('.managed-message').hidden = false;
 
       // Then active views.
       if (extension.views.length > 0) {
         var activeViews = node.querySelector('.active-views');
         activeViews.hidden = false;
         var link = activeViews.querySelector('a');
 
         extension.views.forEach(function(view, i) {
           var label = view.path +
@@ skipping 33 matching lines @@
       if (extension.installWarnings) {
         var panel = node.querySelector('.install-warnings');
         panel.hidden = false;
         var list = panel.querySelector('ul');
         extension.installWarnings.forEach(function(warning) {
           list.appendChild(document.createElement('li')).innerText = warning;
         });
       }
 
       this.appendChild(node);
-    },
+    }
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });