Refactor the various ways to control what users can do to extensions.

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/stl_util.h"
 #include "base/stringprintf.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/convert_user_script.h"
 #include "chrome/browser/extensions/convert_web_app.h"
 #include "chrome/browser/extensions/default_apps_trial.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/permissions_updater.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_icon_set.h"
@@ skipping 171 matching lines @@
 
   // Make sure the manifests match if we want to bypass the prompt.
   if (approved_ &&
       (!expected_manifest_.get() ||
        !expected_manifest_->Equals(original_manifest_.get()))) {
     *error = l10n_util::GetStringUTF16(IDS_EXTENSION_MANIFEST_INVALID);
     return false;
   }
 
   // The checks below are skipped for themes and external installs.
+  // TODO(pamg): After ManagementPolicy refactoring is complete, remove this
+  // and other uses of install_source_ that are no longer needed now that the
+  // SandboxedExtensionUnpacker sets extension->location.

[Aaron Boodman, 2012/05/29 03:03:08]

Hooray.

   if (extension->is_theme() || Extension::IsExternalLocation(install_source_))
     return true;
 
   if (!extensions_enabled_) {
     *error = l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_NOT_ENABLED);
     return false;
   }
 
   if (extension_->is_app()) {
     // If the app was downloaded, apps_require_extension_mime_type_
@@ skipping 110 matching lines @@
 
   if (frontend_weak_->extension_prefs()
       ->IsExtensionBlacklisted(extension_->id())) {
     VLOG(1) << "This extension: " << extension_->id()
             << " is blacklisted. Install failed.";
     ReportFailureFromUIThread(
         l10n_util::GetStringUTF16(IDS_EXTENSION_CANT_INSTALL_BLACKLISTED));
     return;
   }
 
-  if (!frontend_weak_->extension_prefs()->IsExtensionAllowedByPolicy(
-          extension_->id(), install_source_)) {
-    ReportFailureFromUIThread(l10n_util::GetStringFUTF16(
-        IDS_EXTENSION_CANT_INSTALL_POLICY_BLACKLIST,
-        UTF8ToUTF16(extension_->name()),
-        UTF8ToUTF16(extension_->id())));
+  string16 error;
+  if (!ExtensionSystem::Get(profile_)->management_policy()->UserMayLoad(
+      extension_, &error)) {
+    ReportFailureFromUIThread(error);
     return;
   }
 
   GURL overlapping_url;
   const Extension* overlapping_extension =
       frontend_weak_->extensions()->
       GetHostedAppByOverlappingWebExtent(extension_->web_extent());
   if (overlapping_extension &&
       overlapping_extension->id() != extension_->id()) {
     ReportFailureFromUIThread(l10n_util::GetStringFUTF16(
@@ skipping 185 matching lines @@
   // Some users (such as the download shelf) need to know when a
   // CRXInstaller is done.  Listening for the EXTENSION_* events
   // is problematic because they don't know anything about the
   // extension before it is unpacked, so they cannot filter based
   // on the extension.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_CRX_INSTALLER_DONE,
       content::Source<CrxInstaller>(this),
       content::Details<const Extension>(extension));
 }