Fix for broken CertificateViewerUITest.testDetails.

chrome/test/data/webui/certificate_viewer_dialog_test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Test fixture for generated tests.
  * @extends {testing.Test}
  */
-function CertificateViewerUITest() {};
+function CertificateViewerUITest() {}
 
 CertificateViewerUITest.prototype = {
   __proto__: testing.Test.prototype,
 
   /**
    * Define the C++ fixture class and include it.
    * @type {?string}
    * @override
    */
   typedefCppFixture: 'CertificateViewerUITest',
 
   /**
    * Show the certificate viewer dialog.
    */
   testGenPreamble: function() {
     GEN('ShowCertificateViewer();');
   },
 
 };
 
 /**
  * Test fixture for asynchronous tests.
  * @extends {CertificateViewerUITest}
  */
-function CertificateViewerUITestAsync() {};
+function CertificateViewerUITestAsync() {}
 
 CertificateViewerUITestAsync.prototype = {
   __proto__: CertificateViewerUITest.prototype,
 
   /** @inheritDoc */
   isAsync: true,
 };
 
 // Include the bulk of c++ code.
 // Certificate viewer UI tests are disabled on platforms with native certificate
 // viewers.
 GEN('#include "chrome/test/data/webui/certificate_viewer_ui_test-inl.h"');
-GEN('')
+GEN('');
 
 // Constructors and destructors must be provided in .cc to prevent clang errors.
 GEN('CertificateViewerUITest::CertificateViewerUITest() {}');
 GEN('CertificateViewerUITest::~CertificateViewerUITest() {}');
 
 /**
  * Tests that the dialog opened to the correct URL.
  */
 TEST_F('CertificateViewerUITest', 'testDialogURL', function() {
   assertEquals(chrome.expectedUrl, window.location.href);
 });
 
 /**
  * Tests for the correct common name in the test certificate.
  */
 TEST_F('CertificateViewerUITest', 'testCN', function() {
   assertEquals('www.google.com', $('issued-cn').textContent);
 });
 
 /**
  * Test the details pane of the certificate viewer. This verifies that a
  * certificate in the chain can be selected to view the fields. And that fields
  * can be selected to view their values.
- * TODO(flackr,kgr): Re-enable this (http://crbug.com/127732).
  */
-TEST_F('CertificateViewerUITestAsync', 'DISABLED_testDetails', function() {
+TEST_F('CertificateViewerUITestAsync', 'testDetails', function() {
   var certHierarchy = $('hierarchy');
   var certFields = $('cert-fields');
   var certFieldVal = $('cert-field-value');
 
   // There must be at least one certificate in the hierarchy.
   assertLT(0, certHierarchy.childNodes.length);
 
   // Select the first certificate on the chain and ensure the details show up.
   // Override the receive certificate function to catch when fields are
   // loaded.
+  certHierarchy.selectedItem = null;
+  cert_viewer.initializeSecondTab();

[flackr, 2012/05/17 15:46:56]

I don't think this will work since initializeSecondTab isn't exported. Ideally
though as I mentioned in my other comment we would trigger this by selecting the
details tab.

   var getCertificateFields = cert_viewer.getCertificateFields;
   cert_viewer.getCertificateFields = this.continueTest(WhenTestDone.ALWAYS,
       function(certFieldDetails) {
     getCertificateFields(certFieldDetails);
     cert_viewer.getCertificateFields = getCertificateFields;
     assertLT(0, certFields.childNodes.length);
 
     // Test that a field can be selected to see the details for that field.
     var item = getElementWithValue(certFields);
     assertNotEquals(null, item);
@@ skipping 18 matching lines @@
 function getElementWithValue(tree) {
   for (var i = 0; i < tree.childNodes.length; i++) {
     var element = tree.childNodes[i];
     if (element.detail && element.detail.payload && element.detail.payload.val)
       return element;
     if (element = getElementWithValue(element))
       return element;
   }
   return null;
 }