Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 10382144: Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkia (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar_view.h" 5 #include "chrome/browser/ui/views/toolbar_view.h"
6 6
7 #include "base/i18n/number_formatting.h" 7 #include "base/i18n/number_formatting.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 #endif 741 #endif
742 } 742 }
743 743
744 int ToolbarView::PopupTopSpacing() const { 744 int ToolbarView::PopupTopSpacing() const {
745 return GetWidget()->ShouldUseNativeFrame() ? 0 : kPopupTopSpacingNonGlass; 745 return GetWidget()->ShouldUseNativeFrame() ? 0 : kPopupTopSpacingNonGlass;
746 } 746 }
747 747
748 void ToolbarView::LoadImages() { 748 void ToolbarView::LoadImages() {
749 ui::ThemeProvider* tp = GetThemeProvider(); 749 ui::ThemeProvider* tp = GetThemeProvider();
750 750
751 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK)); 751 back_->SetImage(views::CustomButton::BS_NORMAL,
752 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H)); 752 tp->GetImageSkiaNamed(IDR_BACK));
753 back_->SetImage(views::CustomButton::BS_HOT,
754 tp->GetImageSkiaNamed(IDR_BACK_H));
753 back_->SetImage(views::CustomButton::BS_PUSHED, 755 back_->SetImage(views::CustomButton::BS_PUSHED,
754 tp->GetBitmapNamed(IDR_BACK_P)); 756 tp->GetImageSkiaNamed(IDR_BACK_P));
755 back_->SetImage(views::CustomButton::BS_DISABLED, 757 back_->SetImage(views::CustomButton::BS_DISABLED,
756 tp->GetBitmapNamed(IDR_BACK_D)); 758 tp->GetImageSkiaNamed(IDR_BACK_D));
757 759
758 forward_->SetImage(views::CustomButton::BS_NORMAL, 760 forward_->SetImage(views::CustomButton::BS_NORMAL,
759 tp->GetBitmapNamed(IDR_FORWARD)); 761 tp->GetImageSkiaNamed(IDR_FORWARD));
760 forward_->SetImage(views::CustomButton::BS_HOT, 762 forward_->SetImage(views::CustomButton::BS_HOT,
761 tp->GetBitmapNamed(IDR_FORWARD_H)); 763 tp->GetImageSkiaNamed(IDR_FORWARD_H));
762 forward_->SetImage(views::CustomButton::BS_PUSHED, 764 forward_->SetImage(views::CustomButton::BS_PUSHED,
763 tp->GetBitmapNamed(IDR_FORWARD_P)); 765 tp->GetImageSkiaNamed(IDR_FORWARD_P));
764 forward_->SetImage(views::CustomButton::BS_DISABLED, 766 forward_->SetImage(views::CustomButton::BS_DISABLED,
765 tp->GetBitmapNamed(IDR_FORWARD_D)); 767 tp->GetImageSkiaNamed(IDR_FORWARD_D));
766 768
767 reload_->SetImage(views::CustomButton::BS_NORMAL, 769 reload_->SetImage(views::CustomButton::BS_NORMAL,
768 tp->GetBitmapNamed(IDR_RELOAD)); 770 tp->GetImageSkiaNamed(IDR_RELOAD));
769 reload_->SetImage(views::CustomButton::BS_HOT, 771 reload_->SetImage(views::CustomButton::BS_HOT,
770 tp->GetBitmapNamed(IDR_RELOAD_H)); 772 tp->GetImageSkiaNamed(IDR_RELOAD_H));
771 reload_->SetImage(views::CustomButton::BS_PUSHED, 773 reload_->SetImage(views::CustomButton::BS_PUSHED,
772 tp->GetBitmapNamed(IDR_RELOAD_P)); 774 tp->GetImageSkiaNamed(IDR_RELOAD_P));
773 reload_->SetToggledImage(views::CustomButton::BS_NORMAL, 775 reload_->SetToggledImage(views::CustomButton::BS_NORMAL,
774 tp->GetBitmapNamed(IDR_STOP)); 776 tp->GetImageSkiaNamed(IDR_STOP));
775 reload_->SetToggledImage(views::CustomButton::BS_HOT, 777 reload_->SetToggledImage(views::CustomButton::BS_HOT,
776 tp->GetBitmapNamed(IDR_STOP_H)); 778 tp->GetImageSkiaNamed(IDR_STOP_H));
777 reload_->SetToggledImage(views::CustomButton::BS_PUSHED, 779 reload_->SetToggledImage(views::CustomButton::BS_PUSHED,
778 tp->GetBitmapNamed(IDR_STOP_P)); 780 tp->GetImageSkiaNamed(IDR_STOP_P));
779 reload_->SetToggledImage(views::CustomButton::BS_DISABLED, 781 reload_->SetToggledImage(views::CustomButton::BS_DISABLED,
780 tp->GetBitmapNamed(IDR_STOP_D)); 782 tp->GetImageSkiaNamed(IDR_STOP_D));
781 783
782 home_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_HOME)); 784 home_->SetImage(views::CustomButton::BS_NORMAL,
783 home_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_HOME_H)); 785 tp->GetImageSkiaNamed(IDR_HOME));
786 home_->SetImage(views::CustomButton::BS_HOT,
787 tp->GetImageSkiaNamed(IDR_HOME_H));
784 home_->SetImage(views::CustomButton::BS_PUSHED, 788 home_->SetImage(views::CustomButton::BS_PUSHED,
785 tp->GetBitmapNamed(IDR_HOME_P)); 789 tp->GetImageSkiaNamed(IDR_HOME_P));
786 790
787 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL)); 791 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL));
788 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT)); 792 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT));
789 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED)); 793 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED));
790 } 794 }
791 795
792 void ToolbarView::ShowCriticalNotification() { 796 void ToolbarView::ShowCriticalNotification() {
793 #if defined(OS_WIN) 797 #if defined(OS_WIN)
794 CriticalNotificationBubbleView* bubble_delegate = 798 CriticalNotificationBubbleView* bubble_delegate =
795 new CriticalNotificationBubbleView(app_menu_); 799 new CriticalNotificationBubbleView(app_menu_);
796 views::BubbleDelegateView::CreateBubble(bubble_delegate); 800 views::BubbleDelegateView::CreateBubble(bubble_delegate);
797 bubble_delegate->StartFade(true); 801 bubble_delegate->StartFade(true);
798 #endif 802 #endif
799 } 803 }
800 804
801 void ToolbarView::UpdateAppMenuState() { 805 void ToolbarView::UpdateAppMenuState() {
802 string16 accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP); 806 string16 accname_app = l10n_util::GetStringUTF16(IDS_ACCNAME_APP);
803 if (ShouldShowUpgradeRecommended()) { 807 if (ShouldShowUpgradeRecommended()) {
804 accname_app = l10n_util::GetStringFUTF16( 808 accname_app = l10n_util::GetStringFUTF16(
805 IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app); 809 IDS_ACCNAME_APP_UPGRADE_RECOMMENDED, accname_app);
806 } 810 }
807 app_menu_->SetAccessibleName(accname_app); 811 app_menu_->SetAccessibleName(accname_app);
808 812
809 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL)); 813 app_menu_->SetIcon(GetAppMenuIcon(views::CustomButton::BS_NORMAL));
810 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT)); 814 app_menu_->SetHoverIcon(GetAppMenuIcon(views::CustomButton::BS_HOT));
811 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED)); 815 app_menu_->SetPushedIcon(GetAppMenuIcon(views::CustomButton::BS_PUSHED));
812 SchedulePaint(); 816 SchedulePaint();
813 } 817 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698